Skip to content

Commit 3a2a6eb

Browse files
authored
Tidy Playwright LocatorScreenshotOptions overloads (#858)
Make the VerifySettings overload public to match PageScreenshotOptions and ElementScreenshotOptions, and drop the redundant SettingsTask overload that the screenshotOnly overload already covers.
1 parent dbfd9c8 commit 3a2a6eb

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

src/Verify.Playwright/VerifyPlaywright_LocatorScreenshotOptions.cs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,6 @@
22

33
public static partial class VerifyPlaywright
44
{
5-
public static SettingsTask LocatorScreenshotOptions(this SettingsTask settings, LocatorScreenshotOptions options)
6-
{
7-
settings.CurrentSettings.LocatorScreenshotOptions(options);
8-
return settings;
9-
}
10-
115
internal static LocatorScreenshotOptions GetLocatorScreenshotOptions(this IReadOnlyDictionary<string, object> context)
126
{
137
if (context.TryGetValue("Playwright.LocatorScreenshotOptions", out var value))
@@ -23,7 +17,7 @@ internal static LocatorScreenshotOptions GetLocatorScreenshotOptions(this IReadO
2317
};
2418
}
2519

26-
static void LocatorScreenshotOptions(this VerifySettings settings, LocatorScreenshotOptions options) =>
20+
public static void LocatorScreenshotOptions(this VerifySettings settings, LocatorScreenshotOptions options) =>
2721
settings.Context["Playwright.LocatorScreenshotOptions"] = options;
2822

2923
public static SettingsTask LocatorScreenshotOptions(this SettingsTask settings, LocatorScreenshotOptions options, bool screenshotOnly = false)

0 commit comments

Comments
 (0)