Bound each connect attempt in InnerSocketWaiter with a timeout#857
Merged
SimonCropp merged 1 commit intoJun 29, 2026
Merged
Conversation
ReceiveTimeout never applied to ConnectAsync, so a refused connect could block ~2s per attempt (~200s worst case). Use a 100ms CancellationToken per attempt with a fresh socket, giving a bounded ~20s give-up. Add tests.
SimonCropp
deleted the
Bound-each-connect-attempt-in-InnerSocketWaiter-with-a-timeout
branch
github-actions
Bot
restored the
Bound-each-connect-attempt-in-InnerSocketWaiter-with-a-timeout
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReceiveTimeout never applied to ConnectAsync, so a refused connect could block ~2s per attempt (~200s worst case). Use a 100ms CancellationToken per attempt with a fresh socket, giving a bounded ~20s give-up. Add tests.