SET ANSI_NULLS OFF / SET QUOTED_IDENTIFIER OFF not filtered

The fix adds "SET ANSI_NULLS OFF" and "SET QUOTED_IDENTIFIER OFF" to the IsSet filter in   SqlScriptBuilder.cs:208-213. The new SchemaAnsiNullsOff test creates a proc with both settings OFF and verifies they   don't appear in the snapshot output.

Author: SimonCropp

readme.md

@@ -50,7 +50,7 @@ This test:
 ```cs
 await Verify(connection);
 ```
-<sup><a href='/src/Tests/Tests.cs#L300-L304' title='Snippet source file'>snippet source</a> | <a href='#snippet-SqlServerSchema' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L317-L321' title='Snippet source file'>snippet source</a> | <a href='#snippet-SqlServerSchema' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 Will result in the following verified file:
@@ -69,7 +69,7 @@ await Verify(connection)
     // include only tables and views
     .SchemaIncludes(DbObjects.Tables | DbObjects.Views);
 ```
-<sup><a href='/src/Tests/Tests.cs#L666-L672' title='Snippet source file'>snippet source</a> | <a href='#snippet-SchemaInclude' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L683-L689' title='Snippet source file'>snippet source</a> | <a href='#snippet-SchemaInclude' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 Available values:
@@ -107,7 +107,7 @@ await Verify(connection)
         _ => _ is TableViewBase ||
              _.Name == "MyTrigger");
 ```
-<sup><a href='/src/Tests/Tests.cs#L691-L699' title='Snippet source file'>snippet source</a> | <a href='#snippet-SchemaFilter' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L708-L716' title='Snippet source file'>snippet source</a> | <a href='#snippet-SchemaFilter' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 
@@ -129,7 +129,7 @@ command.CommandText = "select Value from MyTable";
 var value = await command.ExecuteScalarAsync();
 await Verify(value!);
 ```
-<sup><a href='/src/Tests/Tests.cs#L475-L485' title='Snippet source file'>snippet source</a> | <a href='#snippet-Recording' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L492-L502' title='Snippet source file'>snippet source</a> | <a href='#snippet-Recording' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 Will result in the following verified file:
@@ -184,7 +184,7 @@ await Verify(
         sqlEntries = entries
     });
 ```
-<sup><a href='/src/Tests/Tests.cs#L552-L582' title='Snippet source file'>snippet source</a> | <a href='#snippet-RecordingSpecific' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L569-L599' title='Snippet source file'>snippet source</a> | <a href='#snippet-RecordingSpecific' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 
@@ -212,7 +212,7 @@ var sqlErrorsViaType = entries
     .Select(_ => _.Data)
     .OfType<ErrorEntry>();
 ```
-<sup><a href='/src/Tests/Tests.cs#L608-L627' title='Snippet source file'>snippet source</a> | <a href='#snippet-RecordingReadingResults' title='Start of snippet'>anchor</a></sup>
+<sup><a href='/src/Tests/Tests.cs#L625-L644' title='Snippet source file'>snippet source</a> | <a href='#snippet-RecordingReadingResults' title='Start of snippet'>anchor</a></sup>
 <!-- endSnippet -->
 
 

src/Tests/Tests.Schema.verified.md

@@ -1,4 +1,4 @@
-## Tables
+## Tables
 
 ### ChildTable
 
@@ -281,6 +281,16 @@ BEGIN
 END;
 ```
 
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```
+
 ### ProcWithParams
 
 ```sql
@@ -390,4 +400,4 @@ CREATE SYNONYM [dbo].[synonym2] FOR [ParentTable]
 
 ```sql
 CREATE SYNONYM [TestSchema].[SchemaSynonym] FOR [TestSchema].[SchemaTable]
-```
+```

src/Tests/Tests.SchemaAnsiNullsOff.verified.md

@@ -0,0 +1,11 @@
+## StoredProcedures
+
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```

src/Tests/Tests.SchemaAsMarkdown.verified.md

@@ -1,4 +1,4 @@
-## Tables
+## Tables
 
 ### ChildTable
 
@@ -281,6 +281,16 @@ BEGIN
 END;
 ```
 
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```
+
 ### ProcWithParams
 
 ```sql
@@ -390,4 +400,4 @@ CREATE SYNONYM [dbo].[synonym2] FOR [ParentTable]
 
 ```sql
 CREATE SYNONYM [TestSchema].[SchemaSynonym] FOR [TestSchema].[SchemaTable]
-```
+```

src/Tests/Tests.SchemaAsSql.verified.sql

@@ -217,6 +217,12 @@ BEGIN
   WHERE (Value > 10);
 END;
 
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+
 CREATE PROCEDURE ProcWithParams
   @Id int,
   @Name nvarchar(100),

src/Tests/Tests.SchemaInDynamic.verified.txt

@@ -283,6 +283,16 @@ BEGIN
 END;
 ```
 
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```
+
 ### ProcWithParams
 
 ```sql

src/Tests/Tests.SchemaIncludeAll.verified.md

@@ -1,4 +1,4 @@
-## Tables
+## Tables
 
 ### ChildTable
 
@@ -281,6 +281,16 @@ BEGIN
 END;
 ```
 
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```
+
 ### ProcWithParams
 
 ```sql
@@ -390,4 +400,4 @@ CREATE SYNONYM [dbo].[synonym2] FOR [ParentTable]
 
 ```sql
 CREATE SYNONYM [TestSchema].[SchemaSynonym] FOR [TestSchema].[SchemaTable]
-```
+```

src/Tests/Tests.SchemaIncludeStoredProceduresOnly.verified.md

@@ -1,4 +1,4 @@
-## StoredProcedures
+## StoredProcedures
 
 ### MyProcedure
 
@@ -13,6 +13,16 @@ BEGIN
 END;
 ```
 
+### ProcWithAnsiNullsOff
+
+```sql
+CREATE PROCEDURE ProcWithAnsiNullsOff
+AS
+BEGIN
+  SELECT Value FROM MyTable;
+END;
+```
+
 ### ProcWithParams
 
 ```sql
@@ -38,4 +48,4 @@ BEGIN
   SELECT Id, Name
   FROM TestSchema.SchemaTable;
 END;
-```
+```

src/Tests/Tests.cs

@@ -287,6 +287,23 @@ FROM TestSchema.SchemaTable
 
                     create synonym TestSchema.SchemaSynonym
                         for TestSchema.SchemaTable;
+                    GO
+
+                    SET ANSI_NULLS OFF;
+                    GO
+                    SET QUOTED_IDENTIFIER OFF;
+                    GO
+
+                    CREATE PROCEDURE ProcWithAnsiNullsOff
+                    AS
+                    BEGIN
+                      SELECT Value FROM MyTable;
+                    END;
+                    GO
+
+                    SET ANSI_NULLS ON;
+                    GO
+                    SET QUOTED_IDENTIFIER ON;
                     """);
                 return Task.CompletedTask;
             });
@@ -789,4 +806,17 @@ public async Task SchemaAsMarkdown()
         await Verify(connection)
             .SchemaAsMarkdown();
     }
+
+    [Test]
+    public async Task SchemaAnsiNullsOff()
+    {
+        await using var database = await sqlInstance.Build();
+        var connection = database.Connection;
+
+        // ProcWithAnsiNullsOff was created with SET ANSI_NULLS OFF and SET QUOTED_IDENTIFIER OFF.
+        // Verify the SET statements are stripped from the output.
+        await Verify(connection)
+            .SchemaFilter(_ => _.Name == "ProcWithAnsiNullsOff")
+            .SchemaIncludes(DbObjects.StoredProcedures);
+    }
 }

src/Verify.SqlServer/SchemaValidation/SqlScriptBuilder.cs

@@ -208,5 +208,7 @@ static List<string> ScriptLines<T>(ScriptingOptions options, T item)
     static bool IsSet(string script) =>
         script is
             "SET ANSI_NULLS ON" or
-            "SET QUOTED_IDENTIFIER ON";
+            "SET ANSI_NULLS OFF" or
+            "SET QUOTED_IDENTIFIER ON" or
+            "SET QUOTED_IDENTIFIER OFF";
 }