Skip to content

Disconnect serverConnection in finally block #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonCropp merged 1 commit into from
Mar 24, 2026
Merged

Disconnect serverConnection in finally block #769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/Verify.SqlServer/SchemaValidation/SqlScriptBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,15 @@ public string BuildContent(SqlConnection connection)
{
ConnectionString = connection.ConnectionString,
};
var server = new Server(serverConnection);

return BuildContent(server, builder);
try
{
var server = new Server(serverConnection);
return BuildContent(server, builder);
}
finally
{
serverConnection.Disconnect();
}
}

string BuildContent(Server server, SqlConnectionStringBuilder builder)
Expand Down
Loading