Commit 69cda1a
committed
Fix chunk-boundary scrubber bugs and test-adapter defects
Scrubbers (Verify core):
- UserMachineScrubber: fix IndexOutOfRangeException when a match ends exactly
on a chunk boundary with a following chunk (read the trailing char via the
builder indexer instead of chunkSpan[neededFromCurrent])
- UserMachineScrubber, GuidScrubber, DirectoryReplacements: roll the carryover
forward across chunks so a token spanning three or more chunks (with a middle
chunk shorter than the token) is no longer silently left unscrubbed
- DateFormatLengthCalculator: 'K' contributes 0 to the minimum length (it can
render as "", "Z" or "+11:00"), so round-trip/"o" formats now scrub the Z and
offset-less forms instead of only the offset form
- LinesScrubber.ReplaceLines: guard the trailing-newline trim on the rebuilt
builder length, not the original string length, fixing an
ArgumentOutOfRangeException when every line is replaced with null
Test-framework adapters:
- MSTest Verifier: only apply TestData parameters when their count matches the
method parameter count (matches XunitV3; params-array DataRows no longer break
parameterized snapshot naming)
- MSTest Verifier_Archive: forward the dropped archiveExtension in the
VerifyZip(Stream) overload
- MSTest TestExecutionContext: resolve Method lazily so the method scan runs
only when a verifier is built
- MSTest source generator: require an attribute list in the syntax predicate so
the uncached CreateSyntaxProvider transform no longer runs semantic work for
every class on every keystroke
- NUnit VerifyBase_Tuple: pass sourceFile so snapshots resolve to the test's
path rather than the package build path
- NUnit VerifyBase_Stream: use settings ?? this.settings in the Task<T> and
ValueTask<T> stream overloads so instance settings are honored
Add repro tests for the scrubber fixes.1 parent aefcdb1 commit 69cda1a
16 files changed
Lines changed: 177 additions & 22 deletions
File tree
- src
- Verify.MSTest.SourceGenerator
- Verify.MSTest
- Verify.NUnit
- Verify.Tests
- Serialization
- Verify/Serialization/Scrubbers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
121 | 125 | | |
122 | | - | |
| 126 | + | |
123 | 127 | | |
124 | 128 | | |
125 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
7 | 12 | | |
8 | 13 | | |
9 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
37 | 42 | | |
38 | 43 | | |
39 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
11 | 11 | | |
12 | 12 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
48 | 51 | | |
49 | 52 | | |
50 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
104 | 121 | | |
105 | 122 | | |
106 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
81 | 104 | | |
82 | 105 | | |
83 | 106 | | |
| |||
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
48 | 64 | | |
49 | 65 | | |
50 | 66 | | |
| |||
0 commit comments