Skip to content

fix: add null safety check and align package versions#1160

Closed
Copilot wants to merge 2 commits into
zoltanszepesi/upgrade-15from
copilot/sub-pr-1159
Closed

fix: add null safety check and align package versions#1160
Copilot wants to merge 2 commits into
zoltanszepesi/upgrade-15from
copilot/sub-pr-1159

Conversation

Copy link
Copy Markdown

Copilot AI commented Jan 1, 2026

Addresses review feedback from the Angular 15 upgrade PR by fixing a potential runtime error and aligning dependency versions.

Changes

  • request.service.ts: Add null check for pageInfo before accessing endCursor in fetchMore() to prevent runtime error if called before initial subscription completes
  • package.json: Update @angular/cli from ~15.2.0 to ~15.2.11 to match devkit packages version
  • package.json: Remove caret prefix from caniuse-lite version specification (1.0.30001762)
async fetchMore() {
  if (!this.pageInfo) {
    return
  }
  
  const result = await this.listQuery.fetchMore({
    variables: {
      last: 20,
      before: this.pageInfo.endCursor,
    },
  })
  // ...
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Jan 1, 2026
Co-authored-by: TwoDCube <14909670+TwoDCube@users.noreply.github.com>
Copilot AI changed the title [WIP] Upgrade Angular and related dependencies to version 15 fix: add null safety check and align package versions Jan 1, 2026
Copilot AI requested a review from TwoDCube January 1, 2026 14:37
@TwoDCube TwoDCube marked this pull request as ready for review January 1, 2026 14:37
@TwoDCube
Copy link
Copy Markdown
Member

TwoDCube commented Jan 1, 2026

@copilot the CI is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants