fix(helm): render queue block + agent detection config; fix image tag, add aws/securityContext#262
Open
nghiadaulau wants to merge 1 commit into
Open
Conversation
…, add aws/securityContext - Move sns/sqs out of alert: into a top-level queue: block — the Go config reads listeners from cfg.Queue.*, so they were silently ignored. - Render the agent regex/redaction/miner/catalog/service_patterns into config.yaml; without regex.default_pattern the agent matched nothing. - Stop forcing a v prefix on image.tag (broke custom tags like :vlocal); only the default falls back to v<appVersion>. - Add the missing aws: values block (nil-pointer when sns/sqs enabled). - Add pod/container securityContext (non-root, drop ALL caps) and standard knobs (imagePullSecrets/nodeSelector/affinity/tolerations/podAnnotations/ extraEnv); probes use the named http port. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Correctness fixes + hardening for the Helm chart, found while deploying the AI agent on minikube.
sns/sqsplacementalert:but the Go config reads listeners fromcfg.Queue.*→ moved to a top-levelqueue:block. SNS/SQS were silently ignored before.regex/redaction/miner/catalog/service_patternsare now rendered intoconfig.yaml. Withoutregex.default_patternthe agent matched nothing and never built a catalog.vprefix —--set image.tag=latestproduced:vlatest. Only the default falls back tov<appVersion>.aws:block.Values.aws.*with no values entry → nil-pointer whensns/sqsenabled.securityContext(non-root uid 65532, drop ALL caps, fsGroup), plusimagePullSecrets/nodeSelector/affinity/tolerations/podAnnotations/extraEnv; probes use the namedhttpport.Verified
helm lintclean ·helm/versus-incident/tests/run.sh→ 4/4 pass · deployed on minikube with Telegram + agent (Gemini viaagent.ai.base_url) working end-to-end.🤖 Generated with Claude Code