feat: report scheduler - webhook auto resolve#297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled incident report + timezone
Added
schedule_enabled,send_time("HH:MM", 24h),timezone("UTC"/IANA)to the report settings table.
New Scheduled daily delivery section: daily send at
send_timeintimezone, reusingdefault_window(window ends at send time) anddefault_channel; timezone also controls the report's printed timestamps(previously UTC-only); schedule gated on the report being enabled; UTC vs
Local-time UI note; HA note (exactly one replica sends the digest).
Added two edge-case bullets (feature off → no send; schedule on/report off →
no send).
Verified against
pkg/services/reportsettings.go(defaults: schedule off,send_time "09:00", timezone "UTC").
Webhook auto resolve
The product decision for webhook auto-resolve changed: auto-resolve must now
ONLY stamp the incident
resolvedin backend storage. It must NOT disable orskip the on-call escalation or the ack (AckURL) path. Default stays ON.
Previously
CreateIncidenttreated an auto-resolved webhook incident like aresolved-from-payload one: it computed
finalResolved = resolved || autoResolveand used that single flag to gate BOTH AckURL injection and on-call escalation,
so an auto-resolved incident got no ack URL and no on-call. That "skip ack +
skip on-call" behaviour is removed.