Skip to content

Commit 08868d1

Browse files
authored
fix: mcp test optimization disabled by default (#1515)
* fix: optimization ON by default for mcp test tool * test: added tests to verify no-optimization flag only when explicitly false
1 parent 586d7c7 commit 08868d1

2 files changed

Lines changed: 19 additions & 5 deletions

File tree

lib/src/mcp/mcp_server.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,9 +314,7 @@ Only one value can be selected.
314314
if (args['recursive'] == true) {
315315
cliArgs.add('-r');
316316
}
317-
if (args['optimization'] == true) {
318-
cliArgs.add('--optimization');
319-
} else {
317+
if (args['optimization'] == false) {
320318
cliArgs.add('--no-optimization');
321319
}
322320
if (args['concurrency'] != null) {

test/src/mcp/mcp_server_test.dart

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,12 +284,29 @@ void main() {
284284
});
285285

286286
group('Tool: test', () {
287-
test('handles basic case with --no-optimization', () async {
287+
test('handles default args (no flags added)', () async {
288288
await sendRequest(
289289
CallToolRequest.methodName,
290290
_params(CallToolRequest(name: 'test', arguments: {})),
291291
);
292292

293+
final capturedArgs =
294+
verify(() => mockCommandRunner.run(captureAny())).captured.first
295+
as List<String>;
296+
expect(capturedArgs, ['test']);
297+
});
298+
299+
test('passes --no-optimization when explicitly false', () async {
300+
await sendRequest(
301+
CallToolRequest.methodName,
302+
_params(
303+
CallToolRequest(
304+
name: 'test',
305+
arguments: {'optimization': false},
306+
),
307+
),
308+
);
309+
293310
final capturedArgs =
294311
verify(() => mockCommandRunner.run(captureAny())).captured.first
295312
as List<String>;
@@ -331,7 +348,6 @@ void main() {
331348
'test',
332349
'--coverage',
333350
'-r',
334-
'--optimization',
335351
'-j',
336352
'8',
337353
'-t',

0 commit comments

Comments
 (0)