fix: address review feedback on PR #1636

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>

Author: unicoderbot[bot]

.gitignore

@@ -37,7 +37,3 @@ CLAUDE.local.md
 
 .codex/
 .cursor/
-
-# act artifacts
-act_output.log
-.secrets

e2e/test/commands/test/very_good_config/malformed_fixture/pubspec.yaml

@@ -0,0 +1,10 @@
+name: malformed_fixture
+description: Fixture for testing malformed very_good.yaml.
+version: 0.1.0+1
+publish_to: none
+
+environment:
+  sdk: ^3.12.0
+
+dev_dependencies:
+  test: ^1.24.3

e2e/test/commands/test/very_good_config/malformed_fixture/very_good.yaml

@@ -0,0 +1,3 @@
+- not
+- a
+- map

e2e/test/commands/test/very_good_config/very_good_config_test.dart

@@ -35,9 +35,10 @@ void main() {
         Directory.current = tempDirectory;
         addTearDown(() => Directory.current = cwd);
 
-        final result = await commandRunner.run(['test', '--coverage']);
-
-        expect(result, equals(ExitCode.unavailable.code));
+        await expectLater(
+          commandRunner.run(['test', '--coverage']),
+          completion(equals(ExitCode.unavailable.code)),
+        );
         verify(
           () => logger.err(any(that: contains('Expected coverage >= 100.00%'))),
         ).called(1);
@@ -71,14 +72,15 @@ void main() {
         Directory.current = tempDirectory;
         addTearDown(() => Directory.current = cwd);
 
-        final result = await commandRunner.run([
-          'test',
-          '--coverage',
-          '--min-coverage',
-          '0',
-        ]);
-
-        expect(result, equals(ExitCode.success.code));
+        await expectLater(
+          commandRunner.run([
+            'test',
+            '--coverage',
+            '--min-coverage',
+            '0',
+          ]),
+          completion(equals(ExitCode.success.code)),
+        );
       }),
     );
 
@@ -91,31 +93,23 @@ void main() {
         );
         addTearDown(() => tempDirectory.deleteSync(recursive: true));
 
-        File(path.join(tempDirectory.path, 'pubspec.yaml')).writeAsStringSync(
-          '''
-name: malformed_fixture
-description: Fixture for testing malformed very_good.yaml.
-version: 0.1.0+1
-publish_to: none
-
-environment:
-  sdk: ^3.12.0
-
-dev_dependencies:
-  test: ^1.24.3
-''',
+        final fixture = Directory(
+          path.join(
+            Directory.current.path,
+            'test/commands/test/very_good_config/malformed_fixture',
+          ),
         );
-        File(
-          path.join(tempDirectory.path, 'very_good.yaml'),
-        ).writeAsStringSync('- not\n- a\n- map');
+
+        await copyDirectory(fixture, tempDirectory);
 
         final cwd = Directory.current;
         Directory.current = tempDirectory;
         addTearDown(() => Directory.current = cwd);
 
-        final result = await commandRunner.run(['test']);
-
-        expect(result, equals(ExitCode.config.code));
+        await expectLater(
+          commandRunner.run(['test']),
+          completion(equals(ExitCode.config.code)),
+        );
         verify(
           () => logger.err(
             any(that: contains('Could not read `very_good.yaml`')),

test/src/commands/test/test_test.dart

@@ -951,8 +951,8 @@ void main() {
             ),
           ),
         );
-        expect(options.minCoverage, 90);
-        expect(options.excludeFromCoverage, '**/*.g.dart');
+        expect(options.minCoverage, equals(90));
+        expect(options.excludeFromCoverage, equals('**/*.g.dart'));
         expect(options.reportOn, equals(['lib/']));
       });
 
@@ -967,23 +967,20 @@ void main() {
             test: VeryGoodTestConfig(minCoverage: '90'),
           ),
         );
-        expect(options.minCoverage, 50);
+        expect(options.minCoverage, equals(50));
       });
 
-      test(
-        'falls back to the CLI default when the parsed arg is null '
-        'and the config is unset',
-        () {
-          when(() => argResults.wasParsed(any())).thenReturn(true);
-          when<dynamic>(
-            () => argResults['collect-coverage-from'],
-          ).thenReturn(null);
+      test('falls back to the CLI default when the parsed arg is null '
+          'and the config is unset', () {
+        when(() => argResults.wasParsed(any())).thenReturn(true);
+        when<dynamic>(
+          () => argResults['collect-coverage-from'],
+        ).thenReturn(null);
 
-          final options = FlutterTestOptions.parse(argResults);
+        final options = FlutterTestOptions.parse(argResults);
 
-          expect(options.collectCoverageFrom, CoverageCollectionMode.imports);
-        },
-      );
+        expect(options.collectCoverageFrom, CoverageCollectionMode.imports);
+      });
     });
   });
 }

test/src/very_good_config/fixtures/all_test_options.yaml

@@ -0,0 +1,23 @@
+test:
+  coverage: true
+  optimization: false
+  concurrency: 8
+  tags: my-tag
+  exclude_coverage: "**/*.g.dart"
+  exclude_tags: skip
+  min_coverage: 95
+  show_uncovered: true
+  collect_coverage_from: all
+  update_goldens: true
+  fail_fast: true
+  dart_define:
+    - FOO=bar
+    - X=42
+  dart_define_from_file: defines.env
+  platform: chrome
+  report_on:
+    - lib/
+    - packages/foo/lib/
+  run_skipped: true
+  flavor: staging
+  timeout: 30

test/src/very_good_config/very_good_config_test.dart

@@ -34,31 +34,16 @@ void main() {
       });
 
       test('parses all supported test options', () {
-        final config = VeryGoodConfig.fromString('''
-test:
-  coverage: true
-  optimization: false
-  concurrency: 8
-  tags: my-tag
-  exclude_coverage: "**/*.g.dart"
-  exclude_tags: skip
-  min_coverage: 95
-  show_uncovered: true
-  collect_coverage_from: all
-  update_goldens: true
-  fail_fast: true
-  dart_define:
-    - FOO=bar
-    - X=42
-  dart_define_from_file: defines.env
-  platform: chrome
-  report_on:
-    - lib/
-    - packages/foo/lib/
-  run_skipped: true
-  flavor: staging
-  timeout: 30
-''');
+        final fixture = File(
+          p.join(
+            'test',
+            'src',
+            'very_good_config',
+            'fixtures',
+            'all_test_options.yaml',
+          ),
+        );
+        final config = VeryGoodConfig.fromString(fixture.readAsStringSync());
 
         expect(config.test.coverage, isTrue);
         expect(config.test.optimization, isFalse);