fix(e2e): add pigeon generation to flutter_plugin (#1587)

* fix(e2e): add pigeon generation to flutter_plugin

* chore: regenerate flutter plugin bundle

* chore: bump templates

* Update e2e/test/commands/create/flutter_plugin/flutter_plugin_test.dart

Author: marcossevilla

e2e/test/commands/create/flutter_plugin/flutter_plugin_test.dart

@@ -33,6 +33,37 @@ void main() {
         'format',
       ], workingDirectory: pluginDirectory);
 
+      // Verify pigeon generated messages.g.dart for each platform that has a
+      // pigeon input file. The check is conditional so it passes when the
+      // fallback bundle (without pigeon) is used.
+      const pigeonPlatforms = ['android', 'ios', 'linux', 'macos', 'windows'];
+      for (final platform in pigeonPlatforms) {
+        final pigeonInput = File(
+          path.join(
+            pluginDirectory,
+            '${pluginName}_$platform',
+            'pigeons',
+            'messages.dart',
+          ),
+        );
+        if (pigeonInput.existsSync()) {
+          final messagesFile = File(
+            path.join(
+              pluginDirectory,
+              '${pluginName}_$platform',
+              'lib',
+              'src',
+              'messages.g.dart',
+            ),
+          );
+          expect(
+            messagesFile.existsSync(),
+            isTrue,
+            reason: 'pigeon did not generate ${messagesFile.path}',
+          );
+        }
+      }
+
       final analyzeResult = await expectSuccessfulProcessResult('flutter', [
         'analyze',
         '.',
@@ -60,6 +91,24 @@ void main() {
         ], workingDirectory: packageDirectory);
         expect(testResult.stdout, contains('All tests passed!'));
 
+        final messagesGenFile = File(
+          path.join(packageDirectory, 'lib', 'src', 'messages.g.dart'),
+        );
+        if (messagesGenFile.existsSync()) {
+          await expectSuccessfulProcessResult(
+            'lcov',
+            [
+              '--remove',
+              'coverage/lcov.info',
+              '*/messages.g.dart',
+              '--output-file',
+              'coverage/lcov.info',
+            ],
+            workingDirectory: packageDirectory,
+            validateStderr: false,
+          );
+        }
+
         final testCoverageResult = await expectSuccessfulProcessResult(
           'genhtml',
           ['coverage/lcov.info', '-o', 'coverage'],

lib/src/cli/dart_cli.dart

@@ -101,6 +101,20 @@ class Dart {
     await Future.wait<void>(processes);
   }
 
+  /// Run pigeon code generation (`dart run pigeon --input <input>`).
+  static Future<void> runPigeon({
+    required Logger logger,
+    required String cwd,
+    required String input,
+  }) async {
+    await _Cmd.run(
+      'dart',
+      ['run', 'pigeon', '--input', input],
+      workingDirectory: cwd,
+      logger: logger,
+    );
+  }
+
   /// Run tests (`dart test`).
   /// Returns a list of exit codes for each test process.
   static Future<List<int>> test({

lib/src/commands/create/templates/post_generate_actions.dart

@@ -1,4 +1,5 @@
 import 'package:mason/mason.dart';
+import 'package:path/path.dart' as p;
 import 'package:universal_io/io.dart';
 import 'package:very_good_cli/src/cli/cli.dart';
 
@@ -11,14 +12,13 @@ Future<bool> installDartPackages(
   bool recursive = false,
 }) async {
   final isDartInstalled = await Dart.installed(logger: logger);
-  if (isDartInstalled) {
-    return Dart.pubGet(
-      cwd: outputDir.path,
-      recursive: recursive,
-      logger: logger,
-    );
-  }
-  return false;
+  if (!isDartInstalled) return false;
+
+  return Dart.pubGet(
+    cwd: outputDir.path,
+    recursive: recursive,
+    logger: logger,
+  );
 }
 
 /// Runs `flutter pub get` in the [outputDir].
@@ -30,14 +30,46 @@ Future<bool> installFlutterPackages(
   bool recursive = false,
 }) async {
   final isFlutterInstalled = await Flutter.installed(logger: logger);
-  if (isFlutterInstalled) {
-    return Flutter.pubGet(
-      cwd: outputDir.path,
-      recursive: recursive,
-      logger: logger,
-    );
-  }
-  return false;
+  if (!isFlutterInstalled) return false;
+
+  return Flutter.pubGet(
+    cwd: outputDir.path,
+    recursive: recursive,
+    logger: logger,
+  );
+}
+
+/// Runs `dart run pigeon` for each platform directory that contains
+/// a `pigeons/messages.dart` input file in the [outputDir].
+///
+/// This is a no-op if Dart is not installed or if no pigeon inputs are found,
+/// which ensures backwards compatibility with template versions that do not
+/// use Pigeon.
+Future<void> generatePigeonCode(Logger logger, Directory outputDir) async {
+  final isDartInstalled = await Dart.installed(logger: logger);
+  if (!isDartInstalled) return;
+
+  final pigeonDirs = outputDir.listSync().whereType<Directory>().where(
+    (d) => File(p.join(d.path, 'pigeons', 'messages.dart')).existsSync(),
+  );
+
+  if (pigeonDirs.isEmpty) return;
+
+  final progress = logger.progress(
+    'Running "dart run pigeon" in ${outputDir.path}',
+  );
+
+  await Future.wait(
+    pigeonDirs.map(
+      (dir) => Dart.runPigeon(
+        cwd: dir.path,
+        logger: logger,
+        input: 'pigeons/messages.dart',
+      ),
+    ),
+  );
+
+  progress.complete();
 }
 
 /// Runs `dart fix --apply` in the [outputDir].
@@ -47,15 +79,17 @@ Future<void> applyDartFixes(
   bool recursive = false,
 }) async {
   final isDartInstalled = await Dart.installed(logger: logger);
-  if (isDartInstalled) {
-    final applyFixesProgress = logger.progress(
-      'Running "dart fix --apply" in ${outputDir.path}',
-    );
-    await Dart.applyFixes(
-      cwd: outputDir.path,
-      recursive: recursive,
-      logger: logger,
-    );
-    applyFixesProgress.complete();
-  }
+  if (!isDartInstalled) return;
+
+  final applyFixesProgress = logger.progress(
+    'Running "dart fix --apply" in ${outputDir.path}',
+  );
+
+  await Dart.applyFixes(
+    cwd: outputDir.path,
+    recursive: recursive,
+    logger: logger,
+  );
+
+  applyFixesProgress.complete();
 }