test: add and improve e2e tests

Author: matiasleyba

e2e/helpers/command_helper.dart

@@ -32,6 +32,7 @@ void Function() withRunner(
     Logger logger,
     PubUpdater pubUpdater,
     List<String> printLogs,
+    List<String> progressLogs,
   )
   runnerFn,
 ) {
@@ -61,6 +62,12 @@ void Function() withRunner(
       () => pubUpdater.getLatestVersion(any()),
     ).thenAnswer((_) => Future.value('1.0.0'));
 
-    await runnerFn(commandRunner, logger, pubUpdater, printLogs);
+    await runnerFn(
+      commandRunner,
+      logger,
+      pubUpdater,
+      printLogs,
+      progressLogs,
+    );
   });
 }

e2e/test/commands/create/dart_cli/dart_cli_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create dart_cli',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/dart_package/dart_pkg_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create dart_package',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/docs_site/docs_site_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create docs_site',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/flame_game/flame_game_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create flame_game',
     timeout: const Timeout(Duration(minutes: 5)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/flutter_app/core_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create flutter_app',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/flutter_package/flutter_pkg_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create flutter_package',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/create/flutter_plugin/flutter_plugin_test.dart

@@ -9,7 +9,7 @@ void main() {
   test(
     'create flutter_plugin',
     timeout: const Timeout(Duration(minutes: 8)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 

e2e/test/commands/packages/check/licenses/licenses_allowed_test.dart

@@ -15,7 +15,7 @@ void main() {
   test(
     'packages check licenses --allowed="MIT,BSD-3-Clause"',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 
@@ -52,6 +52,11 @@ void main() {
         equals(ExitCode.success.code),
         reason: 'Should succeed when allowed licenses are used',
       );
+
+      expect(
+        progressLogs,
+        contains('Retrieved 1 license from 1 package of type: MIT (1).'),
+      );
     }),
   );
 }

e2e/test/commands/packages/check/licenses/licenses_forbidden_test.dart

@@ -1,6 +1,7 @@
 import 'dart:io';
 
 import 'package:mason/mason.dart';
+import 'package:mocktail/mocktail.dart';
 import 'package:path/path.dart' as path;
 import 'package:test/test.dart';
 
@@ -16,7 +17,7 @@ void main() {
   test(
     'packages check licenses --forbidden="MIT"',
     timeout: const Timeout(Duration(minutes: 2)),
-    withRunner((commandRunner, logger, updater, logs) async {
+    withRunner((commandRunner, logger, updater, logs, progressLogs) async {
       final tempDirectory = Directory.systemTemp.createTempSync();
       addTearDown(() => tempDirectory.deleteSync(recursive: true));
 
@@ -54,6 +55,12 @@ void main() {
         equals(ExitCode.config.code),
         reason: 'Should fail when forbidden licenses are used',
       );
+
+      verify(
+        () => logger.err(
+          '1 dependency has a banned license: formz ([MIT](https://pub.dev/packages/formz/license)).',
+        ),
+      ).called(1);
     }),
   );
 }