Skip to content

Commit ed14588

Browse files
committed
fix: failing test
1 parent f471d73 commit ed14588

2 files changed

Lines changed: 9 additions & 34 deletions

File tree

lib/src/cli/dart_cli.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,11 +99,12 @@ class Dart {
9999
required Logger logger,
100100
String cwd = '.',
101101
bool recursive = false,
102+
bool checkIgnore = true,
103+
bool showUncovered = false,
102104
bool collectCoverage = false,
103105
bool optimizePerformance = false,
104106
Set<String> ignore = const {},
105107
double? minCoverage,
106-
bool showUncovered = false,
107108
String? excludeFromCoverage,
108109
CoverageCollectionMode collectCoverageFrom = CoverageCollectionMode.imports,
109110
String? randomSeed,
@@ -113,18 +114,18 @@ class Dart {
113114
void Function(String)? stderr,
114115
GeneratorBuilder buildGenerator = MasonGenerator.fromBundle,
115116
String? reportOn,
116-
bool checkIgnore = false,
117117
}) async {
118118
return TestCLIRunner.test(
119119
logger: logger,
120120
testType: TestRunType.dart,
121121
cwd: cwd,
122122
recursive: recursive,
123+
checkIgnore: checkIgnore,
124+
showUncovered: showUncovered,
123125
collectCoverage: collectCoverage,
124126
optimizePerformance: optimizePerformance,
125127
ignore: ignore,
126128
minCoverage: minCoverage,
127-
showUncovered: showUncovered,
128129
excludeFromCoverage: excludeFromCoverage,
129130
collectCoverageFrom: collectCoverageFrom,
130131
randomSeed: randomSeed,
@@ -134,7 +135,6 @@ class Dart {
134135
stderr: stderr,
135136
reportOn: reportOn,
136137
buildGenerator: buildGenerator,
137-
checkIgnore: checkIgnore,
138138
);
139139
}
140140
}

test/src/commands/dart/commands/dart_test_test.dart

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,11 @@ abstract class DartTestCommandCall {
5959
Future<List<int>> call({
6060
String cwd = '.',
6161
bool recursive = false,
62+
bool checkIgnore = true,
63+
bool showUncovered = false,
6264
bool collectCoverage = false,
6365
bool optimizePerformance = false,
6466
double? minCoverage,
65-
bool showUncovered = false,
6667
String? excludeFromCoverage,
6768
CoverageCollectionMode collectCoverageFrom = CoverageCollectionMode.imports,
6869
String? randomSeed,
@@ -72,7 +73,6 @@ abstract class DartTestCommandCall {
7273
void Function(String)? stderr,
7374
bool? forceAnsi,
7475
String? reportOn,
75-
bool checkIgnore = false,
7676
});
7777
}
7878

@@ -106,10 +106,11 @@ void main() {
106106
() => dartTest(
107107
cwd: any(named: 'cwd'),
108108
recursive: any(named: 'recursive'),
109+
checkIgnore: any(named: 'checkIgnore'),
110+
showUncovered: any(named: 'showUncovered'),
109111
collectCoverage: any(named: 'collectCoverage'),
110112
optimizePerformance: any(named: 'optimizePerformance'),
111113
minCoverage: any(named: 'minCoverage'),
112-
showUncovered: any(named: 'showUncovered'),
113114
excludeFromCoverage: any(named: 'excludeFromCoverage'),
114115
collectCoverageFrom: any(named: 'collectCoverageFrom'),
115116
randomSeed: any(named: 'randomSeed'),
@@ -119,16 +120,15 @@ void main() {
119120
stderr: any(named: 'stderr'),
120121
forceAnsi: any(named: 'forceAnsi'),
121122
reportOn: any(named: 'reportOn'),
122-
checkIgnore: any(named: 'checkIgnore'),
123123
),
124124
).thenAnswer((_) async => [0]);
125125
when<dynamic>(() => argResults['concurrency']).thenReturn(concurrency);
126126
when<dynamic>(() => argResults['recursive']).thenReturn(false);
127127
when<dynamic>(() => argResults['coverage']).thenReturn(false);
128+
when<dynamic>(() => argResults['check-ignore']).thenReturn(true);
128129
when<dynamic>(() => argResults['show-uncovered']).thenReturn(false);
129130
when<dynamic>(() => argResults['fail-fast']).thenReturn(false);
130131
when<dynamic>(() => argResults['run-skipped']).thenReturn(false);
131-
when<dynamic>(() => argResults['check-ignore']).thenReturn(true);
132132
when<dynamic>(() => argResults['optimization']).thenReturn(true);
133133
when<dynamic>(() => argResults['platform']).thenReturn(null);
134134
when<dynamic>(
@@ -211,7 +211,6 @@ void main() {
211211
logger: logger,
212212
stdout: logger.write,
213213
stderr: logger.err,
214-
checkIgnore: true,
215214
),
216215
).called(1);
217216
});
@@ -251,7 +250,6 @@ void main() {
251250
logger: logger,
252251
stdout: logger.write,
253252
stderr: logger.err,
254-
checkIgnore: true,
255253
),
256254
).called(1);
257255
});
@@ -267,7 +265,6 @@ void main() {
267265
logger: logger,
268266
stdout: logger.write,
269267
stderr: logger.err,
270-
checkIgnore: true,
271268
),
272269
).called(1);
273270
});
@@ -282,7 +279,6 @@ void main() {
282279
logger: logger,
283280
stdout: logger.write,
284281
stderr: logger.err,
285-
checkIgnore: true,
286282
),
287283
).called(1);
288284
});
@@ -298,7 +294,6 @@ void main() {
298294
logger: logger,
299295
stdout: logger.write,
300296
stderr: logger.err,
301-
checkIgnore: true,
302297
),
303298
).called(1);
304299
});
@@ -313,7 +308,6 @@ void main() {
313308
logger: logger,
314309
stdout: logger.write,
315310
stderr: logger.err,
316-
checkIgnore: true,
317311
),
318312
).called(1);
319313
});
@@ -328,7 +322,6 @@ void main() {
328322
logger: logger,
329323
stdout: logger.write,
330324
stderr: logger.err,
331-
checkIgnore: true,
332325
),
333326
).called(1);
334327
});
@@ -343,7 +336,6 @@ void main() {
343336
logger: logger,
344337
stdout: logger.write,
345338
stderr: logger.err,
346-
checkIgnore: true,
347339
),
348340
).called(1);
349341
});
@@ -362,7 +354,6 @@ void main() {
362354
logger: logger,
363355
stdout: logger.write,
364356
stderr: logger.err,
365-
checkIgnore: true,
366357
),
367358
).called(1);
368359
});
@@ -384,7 +375,6 @@ void main() {
384375
logger: logger,
385376
stdout: logger.write,
386377
stderr: logger.err,
387-
checkIgnore: true,
388378
),
389379
).called(1);
390380
},
@@ -402,7 +392,6 @@ void main() {
402392
logger: logger,
403393
stdout: logger.write,
404394
stderr: logger.err,
405-
checkIgnore: true,
406395
),
407396
).called(1);
408397
});
@@ -418,7 +407,6 @@ void main() {
418407
logger: logger,
419408
stdout: logger.write,
420409
stderr: logger.err,
421-
checkIgnore: true,
422410
),
423411
).called(1);
424412
});
@@ -434,7 +422,6 @@ void main() {
434422
logger: logger,
435423
stdout: logger.write,
436424
stderr: logger.err,
437-
checkIgnore: true,
438425
),
439426
).called(1);
440427
});
@@ -453,7 +440,6 @@ void main() {
453440
logger: logger,
454441
stdout: logger.write,
455442
stderr: logger.err,
456-
checkIgnore: true,
457443
),
458444
).called(1);
459445
});
@@ -473,7 +459,6 @@ void main() {
473459
logger: logger,
474460
stdout: logger.write,
475461
stderr: logger.err,
476-
checkIgnore: true,
477462
),
478463
).called(1);
479464
},
@@ -496,7 +481,6 @@ void main() {
496481
stdout: logger.write,
497482
stderr: logger.err,
498483
reportOn: 'routes',
499-
checkIgnore: true,
500484
),
501485
).called(1);
502486
},
@@ -533,7 +517,6 @@ void main() {
533517
logger: logger,
534518
stdout: logger.write,
535519
stderr: logger.err,
536-
checkIgnore: true,
537520
),
538521
).called(1);
539522
verify(
@@ -615,7 +598,6 @@ void main() {
615598
logger: logger,
616599
stdout: logger.write,
617600
stderr: logger.err,
618-
checkIgnore: true,
619601
),
620602
).called(1);
621603
verify(
@@ -643,7 +625,6 @@ void main() {
643625
logger: logger,
644626
stdout: logger.write,
645627
stderr: logger.err,
646-
checkIgnore: true,
647628
),
648629
).called(1);
649630
},
@@ -664,7 +645,6 @@ void main() {
664645
logger: logger,
665646
stdout: logger.write,
666647
stderr: logger.err,
667-
checkIgnore: true,
668648
),
669649
).called(1);
670650
},
@@ -697,7 +677,6 @@ void main() {
697677
logger: logger,
698678
stdout: logger.write,
699679
stderr: logger.err,
700-
checkIgnore: true,
701680
),
702681
).called(1);
703682
verify(() => logger.err('$exception')).called(1);
@@ -717,7 +696,6 @@ void main() {
717696
stdout: logger.write,
718697
stderr: logger.err,
719698
forceAnsi: true,
720-
checkIgnore: true,
721699
),
722700
).called(1);
723701
});
@@ -739,7 +717,6 @@ void main() {
739717
logger: logger,
740718
stdout: logger.write,
741719
stderr: logger.err,
742-
checkIgnore: true,
743720
),
744721
).called(1);
745722
},
@@ -763,7 +740,6 @@ void main() {
763740
logger: logger,
764741
stdout: logger.write,
765742
stderr: logger.err,
766-
checkIgnore: true,
767743
),
768744
).called(1);
769745
},
@@ -780,7 +756,6 @@ void main() {
780756
logger: logger,
781757
stdout: logger.write,
782758
stderr: logger.err,
783-
checkIgnore: true,
784759
),
785760
).called(1);
786761
});

0 commit comments

Comments
 (0)