Skip to content

fix: Fixing CI on flutter 3.35 #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzanardo merged 4 commits into from
Aug 18, 2025
Merged

fix: Fixing CI on flutter 3.35 #1339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
da26468
fix: Fixing CI on flutter 3.35
erickzanardo Aug 14, 2025
cd8148a
making core_test checking more robust
erickzanardo Aug 14, 2025
e39d044
license checking test
erickzanardo Aug 14, 2025
e8fb4b4
updating bundle
erickzanardo Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/test/commands/create/flutter_app/core_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void main() {
['coverage/lcov.info', '-o', 'coverage'],
workingDirectory: workingDirectory,
);
expect(testCoverageResult.stdout, contains('lines......: 100.0%'));
expect(testCoverageResult.stdout, matches(RegExp('lines(.+) 100.0%')));
}),
);
}
4 changes: 2 additions & 2 deletions e2e/test/commands/packages/check/licenses/licenses_allowed_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import '../../../../../helpers/helpers.dart';
/// * Run `very_good packages check licenses --allowed="MIT"` and expect success
void main() {
test(
'packages check licenses --allowed="MIT"',
'packages check licenses --allowed="MIT,BSD-3-Clause"',
timeout: const Timeout(Duration(minutes: 2)),
withRunner((commandRunner, logger, updater, logs) async {
final tempDirectory = Directory.systemTemp.createTempSync();
Expand Down Expand Up @@ -44,7 +44,7 @@ void main() {
'packages',
'check',
'licenses',
'--allowed=MIT',
'--allowed=MIT,BSD-3-Clause',
relativeProjectPath,
]);
expect(
Expand Down
Loading