feat: update iOS templates to use UIScene lifecycle #1445
There are no files selected for viewing
|
Member
There was a problem hiding this comment. we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| name: iOS Build Verification | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - "lib/src/commands/create/templates/**" | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - "lib/src/commands/create/templates/**" | ||
|
|
||
| jobs: | ||
| ios-build: | ||
| runs-on: macos-latest | ||
| strategy: | ||
| matrix: | ||
| template: | ||
| - very_good_core | ||
| - very_good_flame_game | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: subosito/flutter-action@v2 | ||
| with: | ||
| flutter-version: "3.38.x" | ||
| channel: stable | ||
|
|
||
| - name: Install Dependencies | ||
| run: dart pub get | ||
|
|
||
| - name: Generate Test Project | ||
| run: | | ||
| if [ "${{ matrix.template }}" = "very_good_core" ]; then | ||
| dart run bin/very_good.dart create flutter_app test_app --template core -o /tmp | ||
| else | ||
| dart run bin/very_good.dart create flutter_app test_app --template ${{ matrix.template }} -o /tmp | ||
| fi | ||
|
|
||
| - name: Build iOS (no-codesign) | ||
| working-directory: /tmp/test_app | ||
| run: flutter build ios --no-codesign --debug | ||
|
|
||
| - name: Verify UIScene Configuration | ||
| run: | | ||
| echo "Checking for UIApplicationSceneManifest in Info.plist..." | ||
| grep -q "UIApplicationSceneManifest" /tmp/test_app/ios/Runner/Info.plist || (echo "FAILED: UIApplicationSceneManifest not found" && exit 1) | ||
|
|
||
| echo "Checking for SceneDelegate.swift..." | ||
| test -f /tmp/test_app/ios/Runner/SceneDelegate.swift || (echo "FAILED: SceneDelegate.swift not found" && exit 1) | ||
|
|
||
| echo "Checking for @main in AppDelegate.swift..." | ||
| grep -q "@main" /tmp/test_app/ios/Runner/AppDelegate.swift || (echo "FAILED: @main not found in AppDelegate.swift" && exit 1) | ||
|
|
||
| echo "Checking for FlutterImplicitEngineDelegate in AppDelegate.swift..." | ||
| grep -q "FlutterImplicitEngineDelegate" /tmp/test_app/ios/Runner/AppDelegate.swift || (echo "FAILED: FlutterImplicitEngineDelegate not found" && exit 1) | ||
|
|
||
| echo "All UIScene configuration checks passed!" |
|
Member
There was a problem hiding this comment. changelog is auto generated by CI too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need this workflow to validate a specific migration on the iOS side, let's remove it and if you can share a video of the UIScene working fine when running iOS, I think that would be more valuable. Thanks!