From b65eb1e2f7c96d407d748cd678c7ad4f815c6dca Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Thu, 5 Mar 2026 18:45:13 +0100 Subject: [PATCH 1/5] feat(test): add check-ignore and run-skipped --- lib/src/cli/dart_cli.dart | 2 + lib/src/cli/test_cli_runner.dart | 2 + .../dart/commands/dart_test_command.dart | 27 ++++++++++ lib/src/mcp/mcp_server.dart | 17 +++++++ test/src/cli/test_cli_runner_test.dart | 50 ++++++++++++++++--- .../dart/commands/dart_test_test.dart | 37 ++++++++++++++ 6 files changed, 127 insertions(+), 8 deletions(-) diff --git a/lib/src/cli/dart_cli.dart b/lib/src/cli/dart_cli.dart index 2bd10e1ce..8e08e4424 100644 --- a/lib/src/cli/dart_cli.dart +++ b/lib/src/cli/dart_cli.dart @@ -113,6 +113,7 @@ class Dart { void Function(String)? stderr, GeneratorBuilder buildGenerator = MasonGenerator.fromBundle, String? reportOn, + bool checkIgnore = false, }) async { return TestCLIRunner.test( logger: logger, @@ -133,6 +134,7 @@ class Dart { stderr: stderr, reportOn: reportOn, buildGenerator: buildGenerator, + checkIgnore: checkIgnore, ); } } diff --git a/lib/src/cli/test_cli_runner.dart b/lib/src/cli/test_cli_runner.dart index cacbed230..21572b3d5 100644 --- a/lib/src/cli/test_cli_runner.dart +++ b/lib/src/cli/test_cli_runner.dart @@ -104,6 +104,7 @@ class TestCLIRunner { void Function(String)? stderr, GeneratorBuilder buildGenerator = MasonGenerator.fromBundle, String? reportOn, + bool checkIgnore = false, @visibleForTesting VeryGoodTestRunner? overrideTestRunner, }) async { final initialCwd = cwd; @@ -206,6 +207,7 @@ class TestCLIRunner { final hitmap = await coverage.HitMap.parseFiles( files, packagePath: packagesPath, + checkIgnoredLines: checkIgnore, ); final resolver = await coverage.Resolver.create( diff --git a/lib/src/commands/dart/commands/dart_test_command.dart b/lib/src/commands/dart/commands/dart_test_command.dart index fd41e6515..37cd0163b 100644 --- a/lib/src/commands/dart/commands/dart_test_command.dart +++ b/lib/src/commands/dart/commands/dart_test_command.dart @@ -26,6 +26,8 @@ class DartTestOptions { required this.platform, required this.rest, required this.reportOn, + required this.runSkipped, + required this.checkIgnore, }); /// Parses [ArgResults] into a [DartTestOptions] instance. @@ -54,6 +56,8 @@ class DartTestOptions { final forceAnsi = argResults['force-ansi'] as bool?; final platform = argResults['platform'] as String?; final reportOn = argResults['report-on'] as String?; + final runSkipped = argResults['run-skipped'] as bool; + final checkIgnore = argResults['check-ignore'] as bool; final rest = argResults.rest; return DartTestOptions._( @@ -71,6 +75,8 @@ class DartTestOptions { forceAnsi: forceAnsi, platform: platform, reportOn: reportOn, + runSkipped: runSkipped, + checkIgnore: checkIgnore, rest: rest, ); } @@ -118,6 +124,12 @@ class DartTestOptions { /// An optional file path to report coverage information to. final String? reportOn; + /// Whether to run skipped tests instead of skipping them. + final bool runSkipped; + + /// Whether to check for and respect coverage ignore comments. + final bool checkIgnore; + /// The remaining arguments passed to the `dart test` command. final List rest; } @@ -143,6 +155,7 @@ typedef DartTestCommandCall = void Function(String)? stdout, void Function(String)? stderr, String? reportOn, + bool checkIgnore, }); /// {@template dart_test_command} @@ -253,6 +266,18 @@ class DartTestCommand extends Command { 'platform', help: 'The platform to run tests on. ', valueHelp: 'chrome|vm', + ) + ..addFlag( + 'run-skipped', + help: 'Run skipped tests instead of skipping them.', + negatable: false, + ) + ..addFlag( + 'check-ignore', + help: + 'Whether to check for and respect coverage ignore comments ' + '(e.g. // coverage:ignore-line).', + negatable: false, ); } @@ -316,11 +341,13 @@ This command should be run from the root of your Dart project.'''); if (options.excludeTags != null) ...['-x', options.excludeTags!], if (options.tags != null) ...['-t', options.tags!], if (options.failFast) '--fail-fast', + if (options.runSkipped) '--run-skipped', if (options.platform != null) ...['--platform', options.platform!], if (options.platform == null) ...['-j', options.concurrency], ...options.rest, ], reportOn: options.reportOn, + checkIgnore: options.checkIgnore, ); if (results.any((code) => code != ExitCode.success.code)) { return ExitCode.unavailable.code; diff --git a/lib/src/mcp/mcp_server.dart b/lib/src/mcp/mcp_server.dart index 95eeceb09..a77aecc75 100644 --- a/lib/src/mcp/mcp_server.dart +++ b/lib/src/mcp/mcp_server.dart @@ -206,6 +206,17 @@ The available values are: chrome, vm, android, ios. Only one value can be selected. ''', ), + 'run_skipped': BooleanSchema( + description: + 'Run skipped tests instead of skipping them. ' + 'Only applies to Dart tests (dart: true).', + ), + 'check_ignore': BooleanSchema( + description: + 'Whether to check for and respect coverage ignore comments ' + '(e.g. // coverage:ignore-line). ' + 'Only applies to Dart tests (dart: true).', + ), }, ), ), @@ -365,6 +376,12 @@ Only one value can be selected. if (args['platform'] != null) { cliArgs.addAll(['--platform', args['platform']! as String]); } + if (args['run_skipped'] == true) { + cliArgs.add('--run-skipped'); + } + if (args['check_ignore'] == true) { + cliArgs.add('--check-ignore'); + } return cliArgs; } diff --git a/test/src/cli/test_cli_runner_test.dart b/test/src/cli/test_cli_runner_test.dart index 7ccadb267..264f51464 100644 --- a/test/src/cli/test_cli_runner_test.dart +++ b/test/src/cli/test_cli_runner_test.dart @@ -780,12 +780,10 @@ void main() { stdout: stdoutLogs.add, stderr: stderrLogs.add, overrideTestRunner: testRunner( - Stream.fromIterable( - [ - const DoneTestEvent(success: true, time: 0), - const ExitTestEvent(exitCode: 0, time: 0), - ], - ), + Stream.fromIterable([ + const DoneTestEvent(success: true, time: 0), + const ExitTestEvent(exitCode: 0, time: 0), + ]), onStart: () { expect(lcovFile.existsSync(), isFalse); lcovFile.createSync(recursive: true); @@ -805,6 +803,42 @@ void main() { expect(testRunnerArgs, equals(['--coverage=coverage'])); }); + test('runs dart tests w/coverage and checkIgnore', () async { + final tempDirectory = Directory.systemTemp.createTempSync(); + addTearDown(() => tempDirectory.deleteSync(recursive: true)); + + final lcovFile = File( + p.join(tempDirectory.path, 'coverage', 'lcov.info'), + ); + File(p.join(tempDirectory.path, 'pubspec.yaml')).createSync(); + Directory(p.join(tempDirectory.path, 'test')).createSync(); + lcovFile.createSync(recursive: true); + + await expectLater( + TestCLIRunner.test( + testType: TestRunType.dart, + cwd: tempDirectory.path, + logger: logger, + checkIgnore: true, + collectCoverage: true, + stdout: stdoutLogs.add, + stderr: stderrLogs.add, + overrideTestRunner: testRunner( + Stream.fromIterable([ + const DoneTestEvent(success: true, time: 0), + const ExitTestEvent(exitCode: 0, time: 0), + ]), + onStart: () { + expect(lcovFile.existsSync(), isFalse); + lcovFile.createSync(recursive: true); + }, + ), + ), + completion(equals([ExitCode.success.code])), + ); + expect(testRunnerArgs, equals(['--coverage=coverage'])); + }); + test('runs tests w/coverage + min-coverage 100 (pass)', () async { final tempDirectory = Directory.systemTemp.createTempSync(); addTearDown(() => tempDirectory.deleteSync(recursive: true)); @@ -816,8 +850,9 @@ void main() { TestCLIRunner.test( testType: TestRunType.flutter, cwd: tempDirectory.path, - collectCoverage: true, + logger: logger, minCoverage: 100, + collectCoverage: true, stdout: stdoutLogs.add, stderr: stderrLogs.add, overrideTestRunner: testRunner( @@ -833,7 +868,6 @@ void main() { ..writeAsStringSync(lcov100); }, ), - logger: logger, ), completion(equals([ExitCode.success.code])), ); diff --git a/test/src/commands/dart/commands/dart_test_test.dart b/test/src/commands/dart/commands/dart_test_test.dart index 1408d0d18..9181e9adb 100644 --- a/test/src/commands/dart/commands/dart_test_test.dart +++ b/test/src/commands/dart/commands/dart_test_test.dart @@ -45,6 +45,8 @@ const expectedTestUsage = [ ' --force-ansi Whether to force ansi output. If not specified, it will maintain the default behavior based on stdout and stderr.\n' ' --report-on= An optional file path to report coverage information to. This should be a path relative to the current working directory.\n' ' --platform= The platform to run tests on. \n' + ' --run-skipped Run skipped tests instead of skipping them.\n' + ' --check-ignore Whether to check for and respect coverage ignore comments (e.g. // coverage:ignore-line).\n' '\n' 'Run "very_good help" to see global options.', ]; @@ -69,6 +71,7 @@ abstract class DartTestCommandCall { void Function(String)? stderr, bool? forceAnsi, String? reportOn, + bool checkIgnore = false, }); } @@ -115,6 +118,7 @@ void main() { stderr: any(named: 'stderr'), forceAnsi: any(named: 'forceAnsi'), reportOn: any(named: 'reportOn'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenAnswer((_) async => [0]); when(() => argResults['concurrency']).thenReturn(concurrency); @@ -122,6 +126,8 @@ void main() { when(() => argResults['coverage']).thenReturn(false); when(() => argResults['show-uncovered']).thenReturn(false); when(() => argResults['fail-fast']).thenReturn(false); + when(() => argResults['run-skipped']).thenReturn(false); + when(() => argResults['check-ignore']).thenReturn(false); when(() => argResults['optimization']).thenReturn(true); when(() => argResults['platform']).thenReturn(null); when( @@ -732,5 +738,36 @@ void main() { ).called(1); }, ); + + test('completes normally --run-skipped', () async { + when(() => argResults['run-skipped']).thenReturn(true); + final result = await testCommand.run(); + expect(result, equals(ExitCode.success.code)); + verify( + () => dartTest( + optimizePerformance: true, + arguments: ['--run-skipped', ...defaultArguments], + logger: logger, + stdout: logger.write, + stderr: logger.err, + ), + ).called(1); + }); + + test('completes normally --check-ignore', () async { + when(() => argResults['check-ignore']).thenReturn(true); + final result = await testCommand.run(); + expect(result, equals(ExitCode.success.code)); + verify( + () => dartTest( + optimizePerformance: true, + arguments: defaultArguments, + logger: logger, + stdout: logger.write, + stderr: logger.err, + checkIgnore: true, + ), + ).called(1); + }); }); } From 1a6e102e1b41db71c08bc1d94d4ce2a4a016b7ae Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Thu, 5 Mar 2026 19:12:30 +0100 Subject: [PATCH 2/5] test(mcp): cover run_skipped and check_ignore in _parseTest --- test/src/mcp/mcp_server_test.dart | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/src/mcp/mcp_server_test.dart b/test/src/mcp/mcp_server_test.dart index 3b5ad73ec..eddd7ad61 100644 --- a/test/src/mcp/mcp_server_test.dart +++ b/test/src/mcp/mcp_server_test.dart @@ -318,6 +318,8 @@ void main() { 'dart-define': 'foo=bar', 'dart-define-from-file': 'my_file.json', 'platform': 'chrome', + 'run_skipped': true, + 'check_ignore': true, }, ), ), @@ -352,6 +354,8 @@ void main() { 'my_file.json', '--platform', 'chrome', + '--run-skipped', + '--check-ignore', ]); }); From 2e870eb8491b64f120fd194eae424ea0e3e6189c Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Fri, 6 Mar 2026 13:14:00 +0100 Subject: [PATCH 3/5] chore: check-ignore true by default --- .../dart/commands/dart_test_command.dart | 2 +- .../dart/commands/dart_test_test.dart | 41 ++++++++++++++++--- 2 files changed, 37 insertions(+), 6 deletions(-) diff --git a/lib/src/commands/dart/commands/dart_test_command.dart b/lib/src/commands/dart/commands/dart_test_command.dart index 37cd0163b..96b15e664 100644 --- a/lib/src/commands/dart/commands/dart_test_command.dart +++ b/lib/src/commands/dart/commands/dart_test_command.dart @@ -274,10 +274,10 @@ class DartTestCommand extends Command { ) ..addFlag( 'check-ignore', + defaultsTo: true, help: 'Whether to check for and respect coverage ignore comments ' '(e.g. // coverage:ignore-line).', - negatable: false, ); } diff --git a/test/src/commands/dart/commands/dart_test_test.dart b/test/src/commands/dart/commands/dart_test_test.dart index 9181e9adb..fe7c2d70e 100644 --- a/test/src/commands/dart/commands/dart_test_test.dart +++ b/test/src/commands/dart/commands/dart_test_test.dart @@ -46,7 +46,8 @@ const expectedTestUsage = [ ' --report-on= An optional file path to report coverage information to. This should be a path relative to the current working directory.\n' ' --platform= The platform to run tests on. \n' ' --run-skipped Run skipped tests instead of skipping them.\n' - ' --check-ignore Whether to check for and respect coverage ignore comments (e.g. // coverage:ignore-line).\n' + ' --[no-]check-ignore Whether to check for and respect coverage ignore comments (e.g. // coverage:ignore-line).\n' + ' (defaults to on)\n' '\n' 'Run "very_good help" to see global options.', ]; @@ -127,7 +128,7 @@ void main() { when(() => argResults['show-uncovered']).thenReturn(false); when(() => argResults['fail-fast']).thenReturn(false); when(() => argResults['run-skipped']).thenReturn(false); - when(() => argResults['check-ignore']).thenReturn(false); + when(() => argResults['check-ignore']).thenReturn(true); when(() => argResults['optimization']).thenReturn(true); when(() => argResults['platform']).thenReturn(null); when( @@ -210,6 +211,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -228,6 +230,7 @@ void main() { logger: any(named: 'logger'), stdout: any(named: 'stdout'), stderr: any(named: 'stderr'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenAnswer( (_) async => [ExitCode.success.code, ExitCode.unavailable.code], @@ -248,6 +251,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -263,6 +267,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -277,6 +282,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -292,6 +298,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -306,6 +313,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -320,6 +328,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -334,6 +343,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -352,6 +362,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -373,6 +384,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -390,6 +402,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -405,6 +418,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -420,6 +434,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -438,6 +453,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); @@ -457,6 +473,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -479,6 +496,7 @@ void main() { stdout: logger.write, stderr: logger.err, reportOn: 'routes', + checkIgnore: true, ), ).called(1); }, @@ -501,6 +519,7 @@ void main() { logger: any(named: 'logger'), stdout: any(named: 'stdout'), stderr: any(named: 'stderr'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenThrow(exception); final result = await testCommand.run(); @@ -514,6 +533,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); verify( @@ -546,6 +566,7 @@ void main() { logger: any(named: 'logger'), stdout: any(named: 'stdout'), stderr: any(named: 'stderr'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenThrow(exception); final result = await testCommand.run(); @@ -580,6 +601,7 @@ void main() { logger: any(named: 'logger'), stdout: any(named: 'stdout'), stderr: any(named: 'stderr'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenThrow(exception); final result = await testCommand.run(); @@ -593,6 +615,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); verify( @@ -620,6 +643,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -640,6 +664,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -660,6 +685,7 @@ void main() { logger: any(named: 'logger'), stdout: any(named: 'stdout'), stderr: any(named: 'stderr'), + checkIgnore: any(named: 'checkIgnore'), ), ).thenThrow(exception); final result = await testCommand.run(); @@ -671,6 +697,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); verify(() => logger.err('$exception')).called(1); @@ -690,6 +717,7 @@ void main() { stdout: logger.write, stderr: logger.err, forceAnsi: true, + checkIgnore: true, ), ).called(1); }); @@ -711,6 +739,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -734,6 +763,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }, @@ -750,12 +780,13 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, + checkIgnore: true, ), ).called(1); }); - test('completes normally --check-ignore', () async { - when(() => argResults['check-ignore']).thenReturn(true); + test('completes normally --no-check-ignore', () async { + when(() => argResults['check-ignore']).thenReturn(false); final result = await testCommand.run(); expect(result, equals(ExitCode.success.code)); verify( @@ -765,7 +796,7 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, + checkIgnore: false, ), ).called(1); }); From ed14588f1dc53261bd624fbc6ab77b981543e39b Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Fri, 6 Mar 2026 13:30:38 +0100 Subject: [PATCH 4/5] fix: failing test --- lib/src/cli/dart_cli.dart | 8 ++--- .../dart/commands/dart_test_test.dart | 35 +++---------------- 2 files changed, 9 insertions(+), 34 deletions(-) diff --git a/lib/src/cli/dart_cli.dart b/lib/src/cli/dart_cli.dart index 8e08e4424..13aa07ed8 100644 --- a/lib/src/cli/dart_cli.dart +++ b/lib/src/cli/dart_cli.dart @@ -99,11 +99,12 @@ class Dart { required Logger logger, String cwd = '.', bool recursive = false, + bool checkIgnore = true, + bool showUncovered = false, bool collectCoverage = false, bool optimizePerformance = false, Set ignore = const {}, double? minCoverage, - bool showUncovered = false, String? excludeFromCoverage, CoverageCollectionMode collectCoverageFrom = CoverageCollectionMode.imports, String? randomSeed, @@ -113,18 +114,18 @@ class Dart { void Function(String)? stderr, GeneratorBuilder buildGenerator = MasonGenerator.fromBundle, String? reportOn, - bool checkIgnore = false, }) async { return TestCLIRunner.test( logger: logger, testType: TestRunType.dart, cwd: cwd, recursive: recursive, + checkIgnore: checkIgnore, + showUncovered: showUncovered, collectCoverage: collectCoverage, optimizePerformance: optimizePerformance, ignore: ignore, minCoverage: minCoverage, - showUncovered: showUncovered, excludeFromCoverage: excludeFromCoverage, collectCoverageFrom: collectCoverageFrom, randomSeed: randomSeed, @@ -134,7 +135,6 @@ class Dart { stderr: stderr, reportOn: reportOn, buildGenerator: buildGenerator, - checkIgnore: checkIgnore, ); } } diff --git a/test/src/commands/dart/commands/dart_test_test.dart b/test/src/commands/dart/commands/dart_test_test.dart index fe7c2d70e..489fed9cf 100644 --- a/test/src/commands/dart/commands/dart_test_test.dart +++ b/test/src/commands/dart/commands/dart_test_test.dart @@ -59,10 +59,11 @@ abstract class DartTestCommandCall { Future> call({ String cwd = '.', bool recursive = false, + bool checkIgnore = true, + bool showUncovered = false, bool collectCoverage = false, bool optimizePerformance = false, double? minCoverage, - bool showUncovered = false, String? excludeFromCoverage, CoverageCollectionMode collectCoverageFrom = CoverageCollectionMode.imports, String? randomSeed, @@ -72,7 +73,6 @@ abstract class DartTestCommandCall { void Function(String)? stderr, bool? forceAnsi, String? reportOn, - bool checkIgnore = false, }); } @@ -106,10 +106,11 @@ void main() { () => dartTest( cwd: any(named: 'cwd'), recursive: any(named: 'recursive'), + checkIgnore: any(named: 'checkIgnore'), + showUncovered: any(named: 'showUncovered'), collectCoverage: any(named: 'collectCoverage'), optimizePerformance: any(named: 'optimizePerformance'), minCoverage: any(named: 'minCoverage'), - showUncovered: any(named: 'showUncovered'), excludeFromCoverage: any(named: 'excludeFromCoverage'), collectCoverageFrom: any(named: 'collectCoverageFrom'), randomSeed: any(named: 'randomSeed'), @@ -119,16 +120,15 @@ void main() { stderr: any(named: 'stderr'), forceAnsi: any(named: 'forceAnsi'), reportOn: any(named: 'reportOn'), - checkIgnore: any(named: 'checkIgnore'), ), ).thenAnswer((_) async => [0]); when(() => argResults['concurrency']).thenReturn(concurrency); when(() => argResults['recursive']).thenReturn(false); when(() => argResults['coverage']).thenReturn(false); + when(() => argResults['check-ignore']).thenReturn(true); when(() => argResults['show-uncovered']).thenReturn(false); when(() => argResults['fail-fast']).thenReturn(false); when(() => argResults['run-skipped']).thenReturn(false); - when(() => argResults['check-ignore']).thenReturn(true); when(() => argResults['optimization']).thenReturn(true); when(() => argResults['platform']).thenReturn(null); when( @@ -211,7 +211,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -251,7 +250,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -267,7 +265,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -282,7 +279,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -298,7 +294,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -313,7 +308,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -328,7 +322,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -343,7 +336,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -362,7 +354,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -384,7 +375,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -402,7 +392,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -418,7 +407,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -434,7 +422,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -453,7 +440,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); @@ -473,7 +459,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -496,7 +481,6 @@ void main() { stdout: logger.write, stderr: logger.err, reportOn: 'routes', - checkIgnore: true, ), ).called(1); }, @@ -533,7 +517,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); verify( @@ -615,7 +598,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); verify( @@ -643,7 +625,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -664,7 +645,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -697,7 +677,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); verify(() => logger.err('$exception')).called(1); @@ -717,7 +696,6 @@ void main() { stdout: logger.write, stderr: logger.err, forceAnsi: true, - checkIgnore: true, ), ).called(1); }); @@ -739,7 +717,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -763,7 +740,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }, @@ -780,7 +756,6 @@ void main() { logger: logger, stdout: logger.write, stderr: logger.err, - checkIgnore: true, ), ).called(1); }); From e14bf00f0f44835a0314de1da89f6d75d34af4d0 Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Fri, 6 Mar 2026 13:35:39 +0100 Subject: [PATCH 5/5] fix: revert bad merge regressions in dart_cli and dart_test_test