fix: skip running pigeon on web platform

marcossevilla · marcossevilla · commit 9a6ef7dc4c96 · 2026-04-14T14:36:21.000+02:00
diff --git a/very_good_dart_package/.gitignore b/very_good_dart_package/.gitignore
@@ -6,6 +6,7 @@
 .dart_tool/
 .packages
 pubspec.lock
+build/
 
 # Files and directories created by mason
 .mason/
diff --git a/very_good_flutter_plugin/__brick__/{{#android}}{{project_name.snakeCase()}}_android{{/android}}/pigeons/copyright.txt b/very_good_flutter_plugin/__brick__/{{#android}}{{project_name.snakeCase()}}_android{{/android}}/pigeons/copyright.txt
@@ -1,2 +1 @@
-Copyright (c) {{currentYear}}, Very Good Ventures
-https://verygood.ventures
+Copyright (c) {{currentYear}}, {{org_name.titleCase()}}
diff --git a/very_good_flutter_plugin/__brick__/{{#android}}{{project_name.snakeCase()}}_android{{/android}}/pigeons/messages.dart b/very_good_flutter_plugin/__brick__/{{#android}}{{project_name.snakeCase()}}_android{{/android}}/pigeons/messages.dart
@@ -1,3 +1,6 @@
+// {{project_name.pascalCase()}}Api must be abstract.
+// ignore_for_file: one_member_abstracts
+
 import 'package:pigeon/pigeon.dart';
 
 @ConfigurePigeon(
diff --git a/very_good_flutter_plugin/__brick__/{{#ios}}{{project_name.snakeCase()}}_ios{{/ios}}/pigeons/copyright.txt b/very_good_flutter_plugin/__brick__/{{#ios}}{{project_name.snakeCase()}}_ios{{/ios}}/pigeons/copyright.txt
@@ -1,2 +1 @@
-Copyright (c) {{currentYear}}, Very Good Ventures
-https://verygood.ventures
+Copyright (c) {{currentYear}}, {{org_name.sentenceCase()}}
diff --git a/very_good_flutter_plugin/__brick__/{{#ios}}{{project_name.snakeCase()}}_ios{{/ios}}/pigeons/messages.dart b/very_good_flutter_plugin/__brick__/{{#ios}}{{project_name.snakeCase()}}_ios{{/ios}}/pigeons/messages.dart
@@ -1,3 +1,6 @@
+// {{project_name.pascalCase()}}Api must be abstract.
+// ignore_for_file: one_member_abstracts
+
 import 'package:pigeon/pigeon.dart';
 
 @ConfigurePigeon(
diff --git a/very_good_flutter_plugin/__brick__/{{#linux}}{{project_name.snakeCase()}}_linux{{/linux}}/pigeons/copyright.txt b/very_good_flutter_plugin/__brick__/{{#linux}}{{project_name.snakeCase()}}_linux{{/linux}}/pigeons/copyright.txt
@@ -1,2 +1 @@
-Copyright (c) {{currentYear}}, Very Good Ventures
-https://verygood.ventures
+Copyright (c) {{currentYear}}, {{org_name.sentenceCase()}}
diff --git a/very_good_flutter_plugin/__brick__/{{#linux}}{{project_name.snakeCase()}}_linux{{/linux}}/pigeons/messages.dart b/very_good_flutter_plugin/__brick__/{{#linux}}{{project_name.snakeCase()}}_linux{{/linux}}/pigeons/messages.dart
@@ -1,3 +1,6 @@
+// {{project_name.pascalCase()}}Api must be abstract.
+// ignore_for_file: one_member_abstracts
+
 import 'package:pigeon/pigeon.dart';
 
 @ConfigurePigeon(
diff --git a/very_good_flutter_plugin/__brick__/{{#macos}}{{project_name.snakeCase()}}_macos{{/macos}}/pigeons/copyright.txt b/very_good_flutter_plugin/__brick__/{{#macos}}{{project_name.snakeCase()}}_macos{{/macos}}/pigeons/copyright.txt
@@ -1,2 +1 @@
-Copyright (c) {{currentYear}}, Very Good Ventures
-https://verygood.ventures
+Copyright (c) {{currentYear}}, {{org_name.sentenceCase()}}
diff --git a/very_good_flutter_plugin/__brick__/{{#macos}}{{project_name.snakeCase()}}_macos{{/macos}}/pigeons/messages.dart b/very_good_flutter_plugin/__brick__/{{#macos}}{{project_name.snakeCase()}}_macos{{/macos}}/pigeons/messages.dart
@@ -1,3 +1,6 @@
+// {{project_name.pascalCase()}}Api must be abstract.
+// ignore_for_file: one_member_abstracts
+
 import 'package:pigeon/pigeon.dart';
 
 @ConfigurePigeon(
diff --git a/very_good_flutter_plugin/__brick__/{{#windows}}{{project_name.snakeCase()}}_windows{{/windows}}/pigeons/copyright.txt b/very_good_flutter_plugin/__brick__/{{#windows}}{{project_name.snakeCase()}}_windows{{/windows}}/pigeons/copyright.txt
@@ -1,2 +1 @@
-Copyright (c) {{currentYear}}, Very Good Ventures
-https://verygood.ventures
+Copyright (c) {{currentYear}}, {{org_name.sentenceCase()}}
diff --git a/very_good_flutter_plugin/__brick__/{{#windows}}{{project_name.snakeCase()}}_windows{{/windows}}/pigeons/messages.dart b/very_good_flutter_plugin/__brick__/{{#windows}}{{project_name.snakeCase()}}_windows{{/windows}}/pigeons/messages.dart
@@ -1,3 +1,6 @@
+// {{project_name.pascalCase()}}Api must be abstract.
+// ignore_for_file: one_member_abstracts
+
 import 'package:pigeon/pigeon.dart';
 
 @ConfigurePigeon(
diff --git a/very_good_flutter_plugin/hooks/lib/version.dart b/very_good_flutter_plugin/hooks/lib/version.dart
@@ -30,3 +30,15 @@ const $availablePlatforms = [
   'web',
   'windows',
 ];
+
+/// The platforms that use Pigeon for native bindings.
+///
+/// Web is excluded because it does not use native code and therefore does not
+/// require Pigeon code generation.
+const $pigeonPlatforms = [
+  'android',
+  'ios',
+  'macos',
+  'linux',
+  'windows',
+];
diff --git a/very_good_flutter_plugin/hooks/post_gen.dart b/very_good_flutter_plugin/hooks/post_gen.dart
@@ -34,7 +34,7 @@ Future<void> run(
   @visibleForTesting VeryGoodCli veryGoodCli = VeryGoodCli.instance,
 }) async {
   final logger = context.logger;
-  final workingDirectory = Directory.current.path;
+  final cwd = Directory.current.path;
 
   if (!await dartCli.isInstalled(logger: logger)) {
     return logger.warn(
@@ -52,17 +52,17 @@ Future<void> run(
 
   await _wrapWithProcessError(
     () => veryGoodCli.packagesGet(
+      cwd: cwd,
       logger: logger,
       recursive: true,
-      cwd: workingDirectory,
     ),
     logger: logger,
   );
 
   final projectName = context.vars[projectNameVariableKey] as String;
-  final directories = $availablePlatforms
+  final directories = $pigeonPlatforms
       .where((platform) => context.vars[platform] as bool)
-      .map((platform) => '$workingDirectory/${projectName}_$platform');
+      .map((platform) => '$cwd/${projectName}_$platform');
 
   progress.update('Generating Pigeon bindings 🦾');
 
@@ -88,8 +88,8 @@ Future<void> run(
     progress.update('Fixing Dart imports ordering 🔨');
     await _wrapWithProcessError(
       () async {
-        await dartCli.fix(logger: logger, cwd: workingDirectory, apply: true);
-        await dartCli.format(logger: logger, cwd: workingDirectory);
+        await dartCli.fix(logger: logger, cwd: cwd, apply: true);
+        await dartCli.format(logger: logger, cwd: cwd);
       },
       logger: logger,
     );
@@ -107,7 +107,7 @@ Future<void> _wrapWithProcessError(
     await process();
   } on ProcessException catch (e) {
     logger.err(
-      '''Running process ${e.executable} with ${e.arguments} failed: ${e.message}''',
+      '''\n\nRunning process ${e.executable} with ${e.arguments} failed: ${e.message}''',
     );
   } on Exception catch (e) {
     logger.err('Unknown error occurred: $e');
diff --git a/very_good_flutter_plugin/hooks/test/post_gen_test.dart b/very_good_flutter_plugin/hooks/test/post_gen_test.dart
@@ -123,7 +123,7 @@ void main() {
           args: any(named: 'args'),
           command: any(named: 'command'),
         ),
-      ).called($availablePlatforms.length);
+      ).called($pigeonPlatforms.length);
     });
 
     group('warns', () {
@@ -181,7 +181,7 @@ void main() {
 
           verify(
             () => logger.err(
-              '''Running process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
+              '''\n\nRunning process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
             ),
           ).called(1);
         },
@@ -278,7 +278,7 @@ void main() {
 
         verify(
           () => logger.err(
-            '''Running process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
+            '''\n\nRunning process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
           ),
         ).called(1);
       });
@@ -321,7 +321,7 @@ void main() {
 
         verify(
           () => logger.err(
-            '''Running process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
+            '''\n\nRunning process ${exception.executable} with ${exception.arguments} failed: ${exception.message}''',
           ),
         ).called(1);
       });

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1 @@`
`1`		`-Copyright (c) {{currentYear}}, Very Good Ventures`
`2`		`-https://verygood.ventures`
	`1`	`+Copyright (c) {{currentYear}}, {{org_name.titleCase()}}`