Skip to content

Commit 5bf4391

Browse files
fix: support multiple paths for report_on (#435)
* fix: support multiple paths for report-on * nits * chore: revert all and activate CLI via git * chore: bump actions for node compat * fix: versions * fix: formatting * chore: update very_good_cli branch * chore: apply suggestions from code review Co-authored-by: Marcos Sevilla <31174242+marcossevilla@users.noreply.github.com>
1 parent 6ec6b7a commit 5bf4391

7 files changed

Lines changed: 13 additions & 14 deletions

File tree

.github/workflows/dart_package.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ jobs:
100100
uses: actions/checkout@v6
101101

102102
- name: 🎯 Setup Dart
103-
uses: dart-lang/setup-dart@v1
103+
uses: dart-lang/setup-dart@v1.7.2
104104
with:
105105
sdk: ${{inputs.dart_sdk}}
106106

@@ -114,7 +114,7 @@ jobs:
114114

115115
- name: 📦 Install Dependencies
116116
run: |
117-
dart pub global activate very_good_cli 1.1.0
117+
dart pub global activate very_good_cli 1.1.1
118118
dart pub get ${{(inputs.no_example && '--no-example') || ''}}
119119
120120
- name: ⚙️ Run Setup
@@ -141,7 +141,7 @@ jobs:
141141
--platform ${{inputs.platform}}
142142
--min-coverage ${{inputs.min_coverage}}
143143
${{inputs.coverage_excludes != '' && format('--exclude-coverage "{0}"', inputs.coverage_excludes) || ''}}
144-
${{format('--report-on {0}', inputs.report_on)}}
144+
${{format('--report-on "{0}"', inputs.report_on)}}
145145
${{inputs.collect_coverage_from != 'imports' && format('--collect-coverage-from {0}', inputs.collect_coverage_from) || ''}}
146146
${{inputs.check_ignore && '--check-ignore' || '--no-check-ignore'}}
147147
${{inputs.show_uncovered && '--show-uncovered' || ''}}

.github/workflows/dart_pub_publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
uses: actions/checkout@v6
4040

4141
- name: 🎯 Setup Dart
42-
uses: dart-lang/setup-dart@v1
42+
uses: dart-lang/setup-dart@v1.7.2
4343
with:
4444
sdk: ${{inputs.dart_sdk}}
4545

.github/workflows/flutter_package.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
uses: actions/checkout@v6
104104

105105
- name: 🐦 Setup Flutter
106-
uses: subosito/flutter-action@v2
106+
uses: subosito/flutter-action@v2.23.0
107107
with:
108108
flutter-version: ${{inputs.flutter_version}}
109109
channel: ${{inputs.flutter_channel}}
@@ -120,7 +120,7 @@ jobs:
120120

121121
- name: 📦 Install Dependencies
122122
run: |
123-
dart pub global activate very_good_cli 1.1.0
123+
dart pub global activate very_good_cli 1.1.1
124124
very_good packages get --recursive --ignore=${{inputs.package_get_excludes}}
125125
126126
- name: ⚙️ Run Setup
@@ -148,7 +148,7 @@ jobs:
148148
--coverage
149149
--min-coverage ${{inputs.min_coverage}}
150150
${{inputs.coverage_excludes != '' && format('--exclude-coverage "{0}"', inputs.coverage_excludes) || ''}}
151-
${{format('--report-on {0}', inputs.report_on)}}
151+
${{format('--report-on "{0}"', inputs.report_on)}}
152152
${{inputs.collect_coverage_from != 'imports' && format('--collect-coverage-from {0}', inputs.collect_coverage_from) || ''}}
153153
${{inputs.show_uncovered && '--show-uncovered' || ''}}
154154
${{inputs.run_skipped && '--run-skipped' || ''}}

.github/workflows/flutter_pub_publish.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
uses: actions/checkout@v6
4444

4545
- name: 🐦 Setup Flutter
46-
uses: subosito/flutter-action@v2
46+
uses: subosito/flutter-action@v2.23.0
4747
with:
4848
flutter-version: ${{inputs.flutter_version}}
4949
channel: ${{inputs.flutter_channel}}
@@ -60,7 +60,7 @@ jobs:
6060
6161
- name: 🎯 Setup Dart
6262
if: ${{ secrets.pub_credentials == '' }}
63-
uses: dart-lang/setup-dart@v1
63+
uses: dart-lang/setup-dart@v1.7.2
6464
with:
6565
sdk: ${{inputs.dart_sdk}}
6666

.github/workflows/license_check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ jobs:
5252
uses: actions/checkout@v6
5353

5454
- name: 🎯 Setup Dart
55-
uses: dart-lang/setup-dart@v1
55+
uses: dart-lang/setup-dart@v1.7.2
5656
with:
5757
sdk: ${{inputs.dart_sdk}}
5858

.github/workflows/mason_publish.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ on:
2727
mason_credentials:
2828
required: true
2929

30-
3130
jobs:
3231
publish:
3332
defaults:
@@ -37,13 +36,13 @@ jobs:
3736
runs-on: ${{inputs.runs_on}}
3837

3938
timeout-minutes: ${{inputs.timeout_minutes}}
40-
39+
4140
steps:
4241
- name: 📚 Git Checkout
4342
uses: actions/checkout@v6
4443

4544
- name: 🎯 Setup Dart
46-
uses: dart-lang/setup-dart@v1
45+
uses: dart-lang/setup-dart@v1.7.2
4746
with:
4847
sdk: ${{inputs.dart_sdk}}
4948

.github/workflows/pana.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
uses: actions/checkout@v6
3333

3434
- name: 🐦 Setup Flutter
35-
uses: subosito/flutter-action@v2
35+
uses: subosito/flutter-action@v2.23.0
3636
with:
3737
channel: stable
3838
cache: true

0 commit comments

Comments
 (0)