Skip to content

fix: flutter_package.yml@main broken: --report-on flag not available in published very_good_cli #431

@Jshewmaker

Description

@Jshewmaker

Description

Body

Affected workflow: .github/workflows/flutter_package.yml
Introduced by: #425

Problem

After PR #425 was merged, flutter_package.yml@main now passes --report-on lib (and --show-uncovered) to very_good test. However, the workflow installs very_good_cli via:

dart pub global activate very_good_cli

The latest published version on pub.dev does not support the --report-on flag, causing all workflows pinned to @main to fail immediately with:

Could not find an option named "--report-on".
Error: Process completed with exit code 64.

Steps To Reproduce

Steps to Reproduce

Any repository using:

uses: VeryGoodOpenSource/very_good_workflows/.github/workflows/flutter_package.yml@main

will fail on the test step after this PR was merged.

Expected Behavior

Expected Behavior

Either:

  1. The workflow changes in refactor: remove coverage action in favor of CLI #425 are backwards compatible.
  2. Breaking change is noted somewhere in docs.

Additional Context

Actual Behavior

Run very_good test -j 4 --optimization --coverage --min-coverage 100 --report-on lib --show-uncovered --test-randomize-ordering-seed random
Could not find an option named "--report-on".
Usage: very_good test [arguments]
...
Error: Process completed with exit code 64.

Workaround

Consumers can temporarily pin to a commit SHA before #425 was merged.

Suggested Fix

Pin the CLI install in the workflow to the version that includes --report-on once it is published:

dart pub global activate very_good_cli <version>

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working as expected

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions