fix: license_check failed on flutter pkgs#352
Closed
JohnWeidner wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
Closed
fix: license_check failed on flutter pkgs#352JohnWeidner wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
JohnWeidner wants to merge 1 commit intoVeryGoodOpenSource:mainfrom
Conversation
marcossevilla
changed the title
matiasleyba
reviewed
Aug 21, 2025
Contributor
matiasleyba
left a comment
matiasleyba
left a comment
There was a problem hiding this comment.
We should also update the doc's site to reflect the changes
| - name: 🎯 Setup Dart | ||
| - name: Show warning if conflicting SDK inputs | ||
| if: ${{ env.SHOW_DART_FLUTTER_WARNING == 'true' }} | ||
| run: echo "::warning::Both 'flutter_version' and 'dart_sdk' were specified. The workflow will proceed with the Flutter SDK setup." |
Member
There was a problem hiding this comment.
I think we should also validate when none were specified right?
Member
|
hey @JohnWeidner, are you able to apply this change or we can close this PR? |
Author
@marcossevilla Sorry this has sat dormant for so many months. Let me see what I can do with it. |
JohnWeidner
force-pushed
the
fix-2970-failed-on-flutter-packages
branch
from
7186c05 to
229b3d0
Compare
Closes VeryGoodOpenSource#297 Allow callers to specify a `flutter_version` or `dart_sdk` to control which SDK is used for dependency resolution. When `flutter_version` is provided, the workflow installs Flutter and uses `flutter pub get`. Otherwise it defaults to the stable Dart SDK with `dart pub get`. - Add `flutter_version` input to license_check workflow - Route SDK setup and dependency install based on input - Warn when both `flutter_version` and `dart_sdk` are specified - Show notice when neither is specified, suggesting `flutter_version` for Flutter projects - Add CI jobs covering all four input combinations - Update docs site to document the new input Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JohnWeidner
force-pushed
the
fix-2970-failed-on-flutter-packages
branch
from
4b05e5a to
cff04ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Closes #297
Now allow caller to specify a flutter_version or a dart_sdk version to indicate which dependencies to get. If you don't specify either it will function as before using the "stable" dart_sdk. If both flutter_version and dart_sdk are specified, it will use flutter dependencies but also display a warning message.
Type of Change