Skip to content

fix: support multiple paths for report_on #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcossevilla merged 9 commits into from
Mar 30, 2026
Merged

fix: support multiple paths for report_on #435

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
32f7caf
fix: support multiple paths for report-on
marcossevilla Mar 24, 2026
7315c70
nits
marcossevilla Mar 25, 2026
720894d
fix: conflicts
marcossevilla Mar 25, 2026
92f3cce
chore: revert all and activate CLI via git
marcossevilla Mar 25, 2026
30e0ed1
chore: bump actions for node compat
marcossevilla Mar 25, 2026
0c24a67
fix: versions
marcossevilla Mar 25, 2026
323c97c
fix: formatting
marcossevilla Mar 25, 2026
f043de9
chore: update very_good_cli branch
marcossevilla Mar 26, 2026
99019e1
chore: apply suggestions from code review
marcossevilla Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/dart_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:
uses: actions/checkout@v6

- name: 🎯 Setup Dart
uses: dart-lang/setup-dart@v1
uses: dart-lang/setup-dart@v1.7.2
with:
sdk: ${{inputs.dart_sdk}}

Expand All @@ -114,7 +114,7 @@ jobs:

- name: 📦 Install Dependencies
run: |
dart pub global activate very_good_cli 1.1.0
dart pub global activate --source git https://github.com/VeryGoodOpenSource/very_good_cli.git --git-ref feat/report-on-multiple-paths
Comment thread
marcossevilla marked this conversation as resolved.
Outdated
dart pub get ${{(inputs.no_example && '--no-example') || ''}}

- name: ⚙️ Run Setup
Expand All @@ -141,7 +141,7 @@ jobs:
--platform ${{inputs.platform}}
--min-coverage ${{inputs.min_coverage}}
${{inputs.coverage_excludes != '' && format('--exclude-coverage "{0}"', inputs.coverage_excludes) || ''}}
${{format('--report-on {0}', inputs.report_on)}}
${{format('--report-on "{0}"', inputs.report_on)}}
${{inputs.collect_coverage_from != 'imports' && format('--collect-coverage-from {0}', inputs.collect_coverage_from) || ''}}
${{inputs.check_ignore && '--check-ignore' || '--no-check-ignore'}}
${{inputs.show_uncovered && '--show-uncovered' || ''}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dart_pub_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
uses: actions/checkout@v6

- name: 🎯 Setup Dart
uses: dart-lang/setup-dart@v1
uses: dart-lang/setup-dart@v1.7.2
with:
sdk: ${{inputs.dart_sdk}}

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/flutter_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ jobs:
uses: actions/checkout@v6

- name: 🐦 Setup Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@v2.23.0
with:
flutter-version: ${{inputs.flutter_version}}
channel: ${{inputs.flutter_channel}}
Expand All @@ -120,7 +120,7 @@ jobs:

- name: 📦 Install Dependencies
run: |
dart pub global activate very_good_cli 1.1.0
dart pub global activate --source git https://github.com/VeryGoodOpenSource/very_good_cli.git --git-ref feat/report-on-multiple-paths
very_good packages get --recursive --ignore=${{inputs.package_get_excludes}}

- name: ⚙️ Run Setup
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
--coverage
--min-coverage ${{inputs.min_coverage}}
${{inputs.coverage_excludes != '' && format('--exclude-coverage "{0}"', inputs.coverage_excludes) || ''}}
${{format('--report-on {0}', inputs.report_on)}}
${{format('--report-on "{0}"', inputs.report_on)}}
${{inputs.collect_coverage_from != 'imports' && format('--collect-coverage-from {0}', inputs.collect_coverage_from) || ''}}
${{inputs.show_uncovered && '--show-uncovered' || ''}}
${{inputs.run_skipped && '--run-skipped' || ''}}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/flutter_pub_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
uses: actions/checkout@v6

- name: 🐦 Setup Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@v2.23.0
with:
flutter-version: ${{inputs.flutter_version}}
channel: ${{inputs.flutter_channel}}
Expand All @@ -60,7 +60,7 @@ jobs:

- name: 🎯 Setup Dart
if: ${{ secrets.pub_credentials == '' }}
uses: dart-lang/setup-dart@v1
uses: dart-lang/setup-dart@v1.7.2
with:
sdk: ${{inputs.dart_sdk}}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/license_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
uses: actions/checkout@v6

- name: 🎯 Setup Dart
uses: dart-lang/setup-dart@v1
uses: dart-lang/setup-dart@v1.7.2
with:
sdk: ${{inputs.dart_sdk}}

Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/mason_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ on:
mason_credentials:
required: true


jobs:
publish:
defaults:
Expand All @@ -37,13 +36,13 @@ jobs:
runs-on: ${{inputs.runs_on}}

timeout-minutes: ${{inputs.timeout_minutes}}

steps:
- name: 📚 Git Checkout
uses: actions/checkout@v6

- name: 🎯 Setup Dart
uses: dart-lang/setup-dart@v1
uses: dart-lang/setup-dart@v1.7.2
with:
sdk: ${{inputs.dart_sdk}}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pana.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
uses: actions/checkout@v6

- name: 🐦 Setup Flutter
uses: subosito/flutter-action@v2
uses: subosito/flutter-action@v2.23.0
with:
channel: stable
cache: true
Expand Down