From 417f6e87e2012b49dbdae8ce10eb504e568d8aa2 Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Fri, 27 Mar 2026 11:42:28 +0100 Subject: [PATCH 1/2] fix: license check for flutter package --- .github/workflows/ci.yml | 12 ++++++++++++ .github/workflows/license_check.yml | 20 +++++++++++++++++++- site/docs/workflows/license_check.md | 16 ++++++++++++++-- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 534fb8c0..624e57d6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -55,6 +55,17 @@ jobs: forbidden: "unknown" skip_packages: "very_good_analysis" + verify-license-check-flutter: + uses: ./.github/workflows/license_check.yml + with: + working_directory: examples/flutter_package + flutter_channel: stable + flutter_version: "3.41.x" + dependency_type: "direct-dev" + allowed: "" + forbidden: "unknown" + skip_packages: "very_good_analysis" + build: needs: [ @@ -65,6 +76,7 @@ jobs: verify-semantic-pull-request, verify-spell-check, verify-license-check, + verify-license-check-flutter, ] runs-on: ubuntu-latest diff --git a/.github/workflows/license_check.yml b/.github/workflows/license_check.yml index 19f8aaae..2ceae4f7 100644 --- a/.github/workflows/license_check.yml +++ b/.github/workflows/license_check.yml @@ -15,6 +15,14 @@ on: required: false type: string default: "stable" + flutter_channel: + required: false + type: string + default: "stable" + flutter_version: + required: false + type: string + default: "" allowed: required: false type: string @@ -52,10 +60,20 @@ jobs: uses: actions/checkout@v6 - name: 🎯 Setup Dart + if: inputs.flutter_version == '' uses: dart-lang/setup-dart@v1 with: sdk: ${{inputs.dart_sdk}} + - name: 🐦 Setup Flutter + if: inputs.flutter_version != '' + uses: subosito/flutter-action@v2 + with: + flutter-version: ${{inputs.flutter_version}} + channel: ${{inputs.flutter_channel}} + cache: true + cache-key: flutter-:os:-:channel:-:version:-:arch:-:hash:-${{ hashFiles('**/pubspec.lock') }} + - name: 🤫 Set SSH Key env: ssh_key: ${{secrets.ssh_key}} @@ -65,7 +83,7 @@ jobs: ssh-private-key: ${{secrets.ssh_key}} - name: 📦 Install Dependencies - run: dart pub get --no-example + run: ${{ inputs.flutter_version != '' && 'flutter' || 'dart' }} pub get --no-example - name: 👨‍⚖️ Check licenses run: | diff --git a/site/docs/workflows/license_check.md b/site/docs/workflows/license_check.md index 4dfc593f..cb6ff6f0 100644 --- a/site/docs/workflows/license_check.md +++ b/site/docs/workflows/license_check.md @@ -14,7 +14,7 @@ The License Check functionality is powered by [Very Good CLI's license checker]( The License Check workflow consists of the following steps: -1. Setup Dart +1. Setup Dart or Flutter 2. Set SSH Key (if provided) 3. Install project dependencies 4. Check licenses @@ -35,10 +35,22 @@ The License Check workflow consists of the following steps: ### `dart_sdk` -**Optional** Which Dart SDK version to use. It can be a version (e.g. `3.5.0`) or a channel (e.g. `stable`): +**Optional** Which Dart SDK version to use. It can be a version (e.g. `3.5.0`) or a channel (e.g. `stable`). Ignored when `flutter_version` is set. **Default** `"stable"` +### `flutter_channel` + +**Optional** The Flutter channel to use (e.g. `stable`, `beta`). Only used when `flutter_version` is set. + +**Default** `"stable"` + +### `flutter_version` + +**Optional** Which Flutter SDK version to use. When set, Flutter is used instead of Dart to install dependencies. It can be a version (e.g. `3.24.0`) or a version constraint (e.g. `3.24.x`). + +**Default** `""` + ### `allowed` **Optional** Only allow the use of certain licenses. The expected format is a comma-separated list. From e068d246034e1f2962d736462023afe86615da6b Mon Sep 17 00:00:00 2001 From: Marcos Sevilla Date: Fri, 27 Mar 2026 11:47:28 +0100 Subject: [PATCH 2/2] chore: use variables --- .github/workflows/license_check.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/license_check.yml b/.github/workflows/license_check.yml index 2ceae4f7..052f5507 100644 --- a/.github/workflows/license_check.yml +++ b/.github/workflows/license_check.yml @@ -55,24 +55,27 @@ jobs: runs-on: ${{inputs.runs_on}} + env: + is_flutter: ${{ inputs.flutter_version != '' }} + steps: - name: 📚 Git Checkout uses: actions/checkout@v6 - name: 🎯 Setup Dart - if: inputs.flutter_version == '' + if: env.is_flutter == 'false' uses: dart-lang/setup-dart@v1 with: sdk: ${{inputs.dart_sdk}} - name: 🐦 Setup Flutter - if: inputs.flutter_version != '' + if: env.is_flutter == 'true' uses: subosito/flutter-action@v2 with: - flutter-version: ${{inputs.flutter_version}} - channel: ${{inputs.flutter_channel}} cache: true + channel: ${{inputs.flutter_channel}} cache-key: flutter-:os:-:channel:-:version:-:arch:-:hash:-${{ hashFiles('**/pubspec.lock') }} + flutter-version: ${{inputs.flutter_version}} - name: 🤫 Set SSH Key env: @@ -83,7 +86,7 @@ jobs: ssh-private-key: ${{secrets.ssh_key}} - name: 📦 Install Dependencies - run: ${{ inputs.flutter_version != '' && 'flutter' || 'dart' }} pub get --no-example + run: ${{ env.is_flutter == 'true' && 'flutter' || 'dart' }} pub get --no-example - name: 👨‍⚖️ Check licenses run: |