Skip to content

fix(ci): exclude CHANGELOG.md from markdown lint and spell check #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryzizub merged 2 commits into from
Apr 7, 2026
Merged

fix(ci): exclude CHANGELOG.md from markdown lint and spell check #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be8fc2e
chore(ci): exclude CHANGELOG.md from markdown lint and spell check
ryzizub Apr 7, 2026
02907cc
Update ci.yaml
ryzizub Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: Lint Markdown
uses: DavidAnson/markdownlint-cli2-action@v23
with:
globs: '**/*.md'
globs: '**/*.md !CHANGELOG.md'
config: 'config/custom.markdownlint.jsonc'
spelling:
name: ✍️ Spelling Check

Check failure on line 20 in .github/workflows/ci.yaml

View check run for this annotation

Claude / Claude Code Review

Glob exclusion syntax broken: space-separated negation not supported 

The glob exclusion syntax used for both actions is broken: space-separated patterns in a single-line string are not split by `getMultilineInput()`, so `\!CHANGELOG.md` is never treated as a separate negation entry. This means the lint and spell-check jobs will either silently pass with zero files examined (matching nothing), or continue to process CHANGELOG.md — the opposite of the intended fix. Both inputs need YAML block scalar syntax (`|`) with each pattern on its own line.
Comment thread
ryzizub marked this conversation as resolved.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- name: Spell Check Code
uses: streetsidesoftware/cspell-action@v8
with:
files: '**/*.md'
files: '**/*.md !CHANGELOG.md'
config: 'config/cspell.json'
detect-changed-skills:
name: 🔎 Detect Changed Skills
Expand Down