fix: use space-separated allowed-tools in skill frontmatter #71
Claude / Claude Code Review
completed
Apr 8, 2026 in 7m 52s
Code review found 1 important issue
Found 5 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 1 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | CLAUDE.md:48-51 |
CONTRIBUTING.md not updated: stale comma-separated allowed-tools format |
| 🟣 Pre-existing | CLAUDE.md:48-54 |
CLAUDE.md Skill File Format spec is incomplete: missing model/effort fields and very-good-analysis-upgrade from structur |
Annotations
Check failure on line 51 in CLAUDE.md
claude / Claude Code Review
CONTRIBUTING.md not updated: stale comma-separated allowed-tools format
CONTRIBUTING.md was not updated by this PR: line 30 shows the old comma-separated example ('allowed-tools: Read,Glob,Grep') and line 39 documents the field as 'Required | Comma-separated list of tools the skill may use', directly contradicting CLAUDE.md (now space-separated, optional) and all 13 updated SKILL.md files. A contributor following CONTRIBUTING.md to create a new skill will use the old comma-separated format — exactly the bug this PR intends to fix — and will also believe the field is
Check notice on line 54 in CLAUDE.md
claude / Claude Code Review
CLAUDE.md Skill File Format spec is incomplete: missing model/effort fields and very-good-analysis-upgrade from structure
CLAUDE.md has two pre-existing documentation gaps that this PR touches but does not fix: (1) the repository structure listing omits skills/very-good-analysis-upgrade/SKILL.md even though the directory exists on disk and is one of the 13 files modified here — CLAUDE.md line 71 explicitly instructs contributors to update the structure listing when adding a skill; (2) the Skill File Format section documents only four frontmatter fields (name, description, allowed-tools, argument-hint) but at least
Loading