Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@

Every `SKILL.md` follows this structure:

1. **YAML frontmatter** with the following fields:
- `name` _(required)_ — prefixed with `vgv-`, lowercase letters, numbers, and hyphens only (e.g., `vgv-bloc`)
- `description` _(required)_ — when the skill should be triggered
- `allowed-tools` _(required)_ — comma-separated list of tools the skill may use (e.g., `Read,Glob,Grep`)
- `allowed-tools` _(optional)_ — space-separated list of tools the skill may use (e.g., `Read Glob Grep`)

Check failure on line 51 in CLAUDE.md

View check run for this annotation

Claude / Claude Code Review

CONTRIBUTING.md not updated: stale comma-separated allowed-tools format

CONTRIBUTING.md was not updated by this PR: line 30 shows the old comma-separated example ('allowed-tools: Read,Glob,Grep') and line 39 documents the field as 'Required | Comma-separated list of tools the skill may use', directly contradicting CLAUDE.md (now space-separated, optional) and all 13 updated SKILL.md files. A contributor following CONTRIBUTING.md to create a new skill will use the old comma-separated format — exactly the bug this PR intends to fix — and will also believe the field is
Comment thread
ryzizub marked this conversation as resolved.
- `argument-hint` _(optional)_ — placeholder hint shown to the user (e.g., `"[file-or-directory]"`)
2. **H1 title** — human-readable skill name
3. **Core Standards** — enforced constraints, always first

Check notice on line 54 in CLAUDE.md

View check run for this annotation

Claude / Claude Code Review

CLAUDE.md Skill File Format spec is incomplete: missing model/effort fields and very-good-analysis-upgrade from structure

CLAUDE.md has two pre-existing documentation gaps that this PR touches but does not fix: (1) the repository structure listing omits skills/very-good-analysis-upgrade/SKILL.md even though the directory exists on disk and is one of the 13 files modified here — CLAUDE.md line 71 explicitly instructs contributors to update the structure listing when adding a skill; (2) the Skill File Format section documents only four frontmatter fields (name, description, allowed-tools, argument-hint) but at least
Comment thread
ryzizub marked this conversation as resolved.
4. **Content sections** — architecture, code examples, workflows, anti-patterns

## Writing Conventions
Expand Down
2 changes: 1 addition & 1 deletion skills/accessibility/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: vgv-accessibility
description: Flutter accessibility auditing and remediation with WCAG 2.1 level selection (A, AA, AAA) across mobile, desktop, and web platforms. Use when building, auditing, or reviewing widgets for screen reader support, touch targets, focus management, color contrast, text scaling, or motion sensitivity. Begins by asking the WCAG conformance level and target platform(s) before applying level-appropriate, platform-aware criteria.
argument-hint: "[wcag-level] [platform]"
allowed-tools: Read,Glob,Grep
allowed-tools: Read Glob Grep
effort: high
---

Expand Down
2 changes: 1 addition & 1 deletion skills/bloc/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-bloc
description: Best practices for Bloc state management in Flutter/Dart. Use when writing, modifying, or reviewing code that uses package:bloc, package:flutter_bloc, or package:bloc_test.
allowed-tools: Read,Glob,Grep
allowed-tools: Read Glob Grep
---

# Bloc
Expand Down
2 changes: 1 addition & 1 deletion skills/create-project/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-create-project
description: Scaffold a new Dart or Flutter project from a Very Good CLI template. Use when user says "create a new project", "start a new flutter app", "scaffold a package", "initialize a dart cli", "new flame game", or "generate a plugin". Supports flutter_app, dart_package, flutter_package, flutter_plugin, dart_cli, flame_game, and docs_site templates.
allowed-tools: mcp__very-good-cli__create,mcp__very-good-cli__packages_get
allowed-tools: mcp__very-good-cli__create mcp__very-good-cli__packages_get
argument-hint: "[template] [project-name]"
model: haiku
effort: low
Expand Down
2 changes: 1 addition & 1 deletion skills/dart-flutter-sdk-upgrade/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ description: >
the exact patch version (e.g., ^3.50.1). Trigger on phrases like "bump Flutter to 3.x",
"update SDK constraints", "upgrade Dart SDK", "update CI Flutter version",
"bump SDK version", or "prep the SDK upgrade PR".
allowed-tools: Read,Glob,Grep,Edit,Write,Bash
allowed-tools: Read Glob Grep Edit Write Bash
model: sonnet
effort: medium
---
Expand Down
2 changes: 1 addition & 1 deletion skills/internationalization/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-internationalization
description: Best practices for internationalization (i18n) and localization (l10n) in Flutter. Use when adding, modifying, or reviewing ARB translations, locale setup, BuildContext l10n extensions, or RTL/directional layout support.
allowed-tools: Read,Glob,Grep
allowed-tools: Read Glob Grep
model: sonnet
---

Expand Down
2 changes: 1 addition & 1 deletion skills/layered-architecture/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-layered-architecture
description: Best practices for VGV layered monorepo architecture in Flutter. Use when structuring a multi-package Flutter app, creating data or repository packages, defining layer boundaries, or wiring dependencies between packages.
allowed-tools: Read,Glob,Grep,mcp__very-good-cli__create,mcp__very-good-cli__packages_get,mcp__very-good-cli__test
allowed-tools: Read Glob Grep mcp__very-good-cli__create mcp__very-good-cli__packages_get mcp__very-good-cli__test
effort: high
---

Expand Down
2 changes: 1 addition & 1 deletion skills/license-compliance/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ description: >
"check dependency licenses", "license compliance", "review package licenses",
"scan for license issues", or "pre-release license check".
argument-hint: "[project-directory]"
allowed-tools: Read,Glob,Grep,mcp__very-good-cli__packages_check_licenses
allowed-tools: Read Glob Grep mcp__very-good-cli__packages_check_licenses
model: sonnet
effort: medium
---
Expand Down
2 changes: 1 addition & 1 deletion skills/material-theming/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-material-theming
description: Best practices for Flutter theming using Material 3. Use when creating, modifying, or reviewing ThemeData, ColorScheme, TextTheme, component themes, spacing systems, or light/dark mode support.
allowed-tools: Read,Glob,Grep
allowed-tools: Read Glob Grep
model: sonnet
---

Expand Down
2 changes: 1 addition & 1 deletion skills/navigation/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-navigation
description: Best practices for navigation and routing in Flutter using GoRouter. Use when creating, modifying, or reviewing routes, deep links, redirects, or navigation logic that uses package:go_router or package:go_router_builder.
allowed-tools: Read,Glob,Grep
allowed-tools: Read Glob Grep
model: sonnet
---

Expand Down
2 changes: 1 addition & 1 deletion skills/static-security/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: >
code that handles secrets, user data, network communication, authentication,
or cryptography. Covers static security concerns — not pen-testing or runtime analysis.
argument-hint: "[file-or-directory]"
allowed-tools: Read,Glob,Grep,mcp__very-good-cli__packages_check_licenses
allowed-tools: Read Glob Grep mcp__very-good-cli__packages_check_licenses
effort: high
---

Expand Down
2 changes: 1 addition & 1 deletion skills/testing/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name: vgv-testing
description: Best practices for Dart unit tests, Flutter widget tests, and golden file tests. Use when writing, modifying, or reviewing tests that use package:test, package:flutter_test, package:mocktail, or package:bloc_test.
argument-hint: "[file-or-directory]"
allowed-tools: Read,Glob,Grep,mcp__very-good-cli__test
allowed-tools: Read Glob Grep mcp__very-good-cli__test
---

# Dart & Flutter Testing
Expand Down
2 changes: 1 addition & 1 deletion skills/ui-package/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-ui-package
description: Best practices for building a Flutter UI package on top of Material — custom components, ThemeExtension-based theming, consistent APIs, and widget tests. Use when user says "create a ui package". Supports app_ui_package template.
allowed-tools: Edit,mcp__very-good-cli__create
allowed-tools: Edit mcp__very-good-cli__create
model: sonnet
---

Expand Down
2 changes: 1 addition & 1 deletion skills/very-good-analysis-upgrade/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
name: vgv-very-good-analysis-upgrade
description: Upgrade very_good_analysis lint package to new version across Dart/Flutter projects. Handles version bump, lint fixes, and PR creation.
allowed-tools: Read,Glob,Grep,Bash
allowed-tools: Read Glob Grep Bash
model: sonnet
effort: medium
---
Expand Down
Loading