Skip to content

Commit 2fb2b60

Browse files
authored
feat: extracted shared review consolidation to reference (#155)
1 parent f7dabbf commit 2fb2b60

7 files changed

Lines changed: 28 additions & 26 deletions

File tree

skills/build/SKILL.md

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -152,21 +152,7 @@ The 5 agents and their report filenames:
152152

153153
### After all reviews complete
154154

155-
1. **Consolidate findings** from all summaries into three categories:
156-
- **Critical** (must fix before merge): Bugs, missing tests, layer violations, broken analysis
157-
- **Important** (should fix): Convention deviations, test gaps, naming issues
158-
- **Suggestions** (note for PR): Style improvements, minor simplifications
159-
160-
2. **Auto-fix minor issues**: formatting (run the project's formatter), lint warnings. Stage and commit fixes.
161-
162-
3. **Fix critical issues**: Read the specific report file (e.g., `docs/reviews/architecture-review.md`) for full details on each critical finding. Address each one, re-run validation (project's linter and test runner), and commit. Only read reports that contain critical issues — do not load all 5 reports into context.
163-
164-
4. **Present important issues** to the user via **AskUserQuestion**:
165-
- **Fix all**: address every important issue (read relevant report files for details)
166-
- **Review the list first**: show the full list for the user to decide
167-
- **Skip to shipping**: note them in the PR description instead
168-
169-
5. **Record suggestions** for inclusion in the PR description.
155+
Follow the [review consolidation procedure](references/review-consolidation.md): categorize findings, auto-fix minor issues, fix critical issues, present important issues to the user, and record suggestions.
170156

171157
## Phase 4 — Ship
172158

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../shared/references/review-consolidation.md

skills/hotfix/SKILL.md

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -133,13 +133,7 @@ The 2 agents and their report filenames:
133133

134134
### After reviews complete
135135

136-
1. **Critical findings** → Read the specific report file (e.g., `docs/hotfix-review/vgv-review.md`) for full details on each critical finding. Fix immediately, re-run validation, and commit. Only read reports that contain critical issues — do not load both reports into context unnecessarily.
137-
138-
2. **Important findings** → use **AskUserQuestion**:
139-
- **Fix all**: address every important issue (read relevant report files for details)
140-
- **Skip to shipping**: note them in the PR description
141-
142-
3. **Suggestions** → record for PR description.
136+
Follow the [review consolidation procedure](references/review-consolidation.md): fix critical issues, present important issues to the user, and record suggestions.
143137

144138
### Cleanup
145139

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../shared/references/review-consolidation.md

skills/review/SKILL.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,7 @@ Default agents and their report filenames:
9797
9898
After all reviews complete:
9999
100-
1. **Consolidate findings** from all summaries into three categories:
101-
- **Critical** (must fix before merge): Bugs, missing tests, layer violations, broken analysis
102-
- **Important** (should fix): Convention deviations, test gaps, naming issues
103-
- **Suggestions** (nice to have): Style improvements, minor simplifications
100+
1. [Categorize findings](references/review-consolidation.md) from all summaries into Critical, Important, and Suggestions.
104101
105102
2. **Present the consolidated summary** to the user with counts per category and the one-line descriptions from each agent.
106103
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../../shared/references/review-consolidation.md
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Review Consolidation
2+
3+
## Categorize findings
4+
5+
Consolidate findings from all agent summaries into three categories:
6+
7+
- **Critical** (must fix before merge): Bugs, missing tests, layer violations, broken analysis
8+
- **Important** (should fix): Convention deviations, test gaps, naming issues
9+
- **Suggestions** (note for PR): Style improvements, minor simplifications
10+
11+
## Fix and triage
12+
13+
1. **Auto-fix minor issues**: formatting (run the project's formatter), lint warnings. Stage and commit fixes.
14+
15+
2. **Fix critical issues**: Read the specific report file for full details on each critical finding. Address each one, re-run validation (project's linter and test runner), and commit. Only read reports that contain critical issues — do not load all reports into context.
16+
17+
3. **Present important issues** to the user via **AskUserQuestion**:
18+
- **Fix all**: address every important issue (read relevant report files for details)
19+
- **Review the list first**: show the full list for the user to decide
20+
- **Skip to shipping**: note them in the PR description instead
21+
22+
4. **Record suggestions** for inclusion in the PR description.

0 commit comments

Comments
 (0)