Problem
The /simplify skill reviews the diff for code reuse, quality, and efficiency issues within the changed code. However, it does not cross-reference against findings from prior codebase reviews (e.g., from codebase-review-agent) to check whether new code repeats known issues.
Example
During a session working on the wger-flutter project:
- The initial
codebase-review-agent run identified that the app uses localized strings (AppLocalizations) throughout the codebase
- New code was written with hardcoded English strings (e.g.,
'Health sync', 'Import weight from Apple Health or Health Connect')
/simplify was run and flagged several valid issues (duplicate date logic, O(n*m) dedup, redundant comments) but did not flag the hardcoded strings
- The user manually caught the l10n issue
The /simplify agents correctly reviewed the diff in isolation, but missed that the new code introduced the same class of problem the codebase review had already identified.
Suggestion
The /codebase-review-agent should save the assessment as a review document.
When a codebase review document exists (e.g., in wingspan/reviews/), the /simplify skill (or one of its sub-agents) could:
- Read the most recent codebase review findings
- Check whether the diff introduces code that violates any of the documented conventions or repeats known issues
- Flag these as "previously identified convention" violations
This would close the gap between "what we know about the codebase" and "what we check in new code."
Problem
The
/simplifyskill reviews the diff for code reuse, quality, and efficiency issues within the changed code. However, it does not cross-reference against findings from prior codebase reviews (e.g., fromcodebase-review-agent) to check whether new code repeats known issues.Example
During a session working on the wger-flutter project:
codebase-review-agentrun identified that the app uses localized strings (AppLocalizations) throughout the codebase'Health sync','Import weight from Apple Health or Health Connect')/simplifywas run and flagged several valid issues (duplicate date logic, O(n*m) dedup, redundant comments) but did not flag the hardcoded stringsThe
/simplifyagents correctly reviewed the diff in isolation, but missed that the new code introduced the same class of problem the codebase review had already identified.Suggestion
The /codebase-review-agent should save the assessment as a review document.
When a codebase review document exists (e.g., in
wingspan/reviews/), the/simplifyskill (or one of its sub-agents) could:This would close the gap between "what we know about the codebase" and "what we check in new code."