feat(review): consolidate output into one numbered report with best-practices checks#210
Merged
Conversation
…ractices checks Emit a single consolidated review file per run instead of one file per agent. Each agent writes its detailed report to a raw/ subdirectory and returns a structured findings list; the calling skill deduplicates, orders deterministically (severity → file → line → rule), and assigns stable FINDING-NN ids plus a <category>/<rule> class id. The chat summary renders from that same ordered list, so ids, order, and titles match between chat and file, and the user can act by finding id or by rule. Applies to /review, /build, and /hotfix; ephemeral cleanup still removes the whole output directory. Add best-practices-review-agent: validates changed code against current official documentation and best practices (deprecation checks, citations), including a Claude/Anthropic SDK checklist gated to code that uses the SDK. Wired into /review and /build, offered conditionally in /hotfix. Closes #179 Closes #180 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
6 tasks
…defects Drop the best-practices-review-agent and its wiring — the "review against docs" reading was a misunderstanding; the ask was to author the review skill well. Build returns to 5 agents, /review to 4, hotfix to its reduced set. Fix the cross-file contract defects found auditing the skill against Anthropic Claude Code authoring standards: - `<name>` is a bare stem so agents write `<RAW_DIR>/<name>.md` (no raw/raw/x.md.md) - build/hotfix resolve an absolute RAW_DIR via pwd - the shared "Acting on findings" step is neutral; each skill owns its post-review menu - one chat-summary contract: Critical+Important verbatim, Suggestions collapsed - define the Critical/Important/Suggestion taxonomy and how agents map onto it - drop location "-"; define where a bare-file finding sorts - /review isolates each run under docs/code-review/<slug>/ (no raw/ clobber) - correct the id-stability claim; specify the merge survivor rule id; custom-agent derivation - deterministic path-scope slug; build/hotfix commits don't cite deleted-report ids - hotfix gains agent-failure handling; correct the "raw not read back" claim Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # config/cspell.json # skills/build/SKILL.md
omartinma
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overhauls the review output into one numbered report and hardens the review skill's authoring.
/review,/build, and/hotfixnow emit a single review file instead of one per agent. Per-agent detail moves to a linkedraw/subdir;/reviewisolates each run underdocs/code-review/<slug>/; ephemeral cleanup is unchanged.FINDING-NNids plus a<category>/<rule>class id. The chat summary and the file render from the same list (same ids, order, titles), so you can act by number ("fix all except 3 and 4") or by rule.RAW_DIR/<name>contract, one chat-summary rule, a defined Critical/Important/Suggestion taxonomy with agent mapping, a deterministic scope slug, and each skill owning its own post-review menu.Verified with an adversarial review workflow (15/16 defects resolved on the first pass, remainder fixed after);
markdownlint,cspell, andclaude plugin validateall clean.Closes #179
Closes #180
Closes #194
Type of Change
feat)fix)refactor)docs)ci)chore)🤖 Generated with Claude Code