feat(review): add option to file findings on the PR as comments#214
Open
ryzizub wants to merge 2 commits into
Open
feat(review): add option to file findings on the PR as comments#214ryzizub wants to merge 2 commits into
ryzizub wants to merge 2 commits into
Conversation
ryzizub
force-pushed
the
feat/review-file-findings-on-pr
branch
from
b4ddbb4 to
04beb4f
Compare
ryzizub
changed the title
Add a post-review option to /review Step 4 that posts selected findings to the branch's pull request. The user chooses which findings (all, critical+important, or specific FINDING-NN ids); each is posted as an inline comment anchored to its file:line via gh/glab, with a single summary comment as fallback when a line is not on the diff or no PR/CLI is available. Mechanism lives in a new shared reference (file-findings-on-pr.md), symlinked into the review skill; allowed-tools now permits gh/glab. Also fix the Step 4 pointer to the renamed "Act (by id or rule)" consolidation heading. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ryzizub
force-pushed
the
feat/review-file-findings-on-pr
branch
from
04beb4f to
15dcfeb
Compare
omartinma
reviewed
Jul 3, 2026
| - **Fix critical + important**: same, plus Important findings. | ||
| - **Fix specific findings**: accept ids from the user (e.g. "FINDING-01, FINDING-04"), or a | ||
| rule id to act on a whole class (e.g. "fix every `tests/missing-test-file`"). | ||
| - **File findings on the PR as comments**: post selected findings to the branch's pull |
Contributor
There was a problem hiding this comment.
Should we not have a user validation here to confirm they agree with the message that is going to be posted, and not just the finding?
Contributor
Author
There was a problem hiding this comment.
True i was focusing on filtering what user wants to post
… to post) Address review feedback: make filing findings on the PR a two-step choice. First the user picks which findings are worth posting; then, after previewing the drafted comments, they choose how to deliver — inline comments, one summary comment, or print the drafts to post manually. Nothing posts without both choices, keeping AI-review verbosity from landing on the PR unasked. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a post-review option to
/review: file selected findings on the branch's pull request as comments.FINDING-NNids), and each is posted as an inline comment anchored to itsfile:lineviagh/glab, with a single summary comment as fallback when a line isn't on the diff or no PR/CLI is available.file-findings-on-pr.md(symlinked into the review skill);allowed-toolsnow permitsgh/glab.Builds on the consolidated
FINDING-NNreview output from #210 (now merged tomain).markdownlint,cspell, andclaude plugin validateall clean.Type of Change
feat)fix)refactor)docs)ci)chore)🤖 Generated with Claude Code