feat(agents): discover companion-plugin skills in review agents#215
Draft
ryzizub wants to merge 1 commit into
Draft
feat(agents): discover companion-plugin skills in review agents#215ryzizub wants to merge 1 commit into
ryzizub wants to merge 1 commit into
Conversation
Add a companion-plugin skill-discovery step to the review agents so they apply technology-specific conventions (state management, testing, layered architecture, navigation, etc.) from installed companion plugins on top of VGV standards. Each agent globs for SKILL.md files, filters by frontmatter domain, and reads the relevant ones; it falls back to VGV defaults when none are found. - vgv-review, architecture-review, test-quality-review: extend the tech-stack step - code-simplicity-review: add a Phase 0 discovery step and <examples> to the description - codebase-review: add a tech-stack detection + Phase 0 discovery preamble Closes #189 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Teaches the review agents to pick up technology-specific conventions from installed companion plugins, so a review enforces companion-plugin patterns (state management, testing, layered architecture, navigation, …) on top of VGV's defaults — not just VGV standards.
Each agent discovers independently: glob for
SKILL.mdfiles (**/skills/**/SKILL.md,~/.claude/plugins/**/SKILL.md,.claude/skills/**/SKILL.md), filter by frontmatter domain, read the relevant ones, and enforce their documented patterns. Falls back to VGV defaults when no companion skills are found — best-effort, never blocks the review.Agents modified:
vgv-review-agent,architecture-review-agent,test-quality-review-agent— extend the existing "detect tech stack" step with discovery.code-simplicity-review-agent— add a Phase 0 discovery step (so a documented idiom isn't flagged as a simplification target) and add<examples>to its description.codebase-review-agent— add a tech-stack detection + Phase 0 discovery preamble.markdownlint,cspell, andclaude plugin validateall clean.Closes #189
Type of Change
feat)fix)refactor)docs)ci)chore)🤖 Generated with Claude Code