Test GH actions#1
Open
Vest wants to merge 89 commits into
Open
Conversation
Added some logging.
Test Results 1 123 files 1 123 suites 12m 59s ⏱️ For more details on these failures, see this check. Results for commit 2555af3. ♻️ This comment has been updated with latest results. |
Removed explicit System.exit(0) in Main. It allows to enable "slowtest" that generates and compares XMLs. Marked SystemExitInterceptor as deprecated and removal=true. Since Java does not offer any alternative, we have to find a better solution. P.S. NSIS is planned to be removed to use jpackage only.
…s StackTrace to determine the logger name. This is expensive and replaced with an explicit logger creation.
…methods that return null. In some cases, the null reference/result was not checked, but the code never failed, because it was not executed. There were no tests, that is why it was difficult to check, whether the refactoring was right :(
Update gh_build
1. Corrected the typo in special properties (light crossbow); 2. Corrected maxdex for MAXDEX bonus;
# Conflicts: # data/pathfinder/paizo/roleplaying_game/core_rulebook/cr_equip_arms_armor.lst
…e the difference between "golden" and generated files). Trimmed lines in base.xml and base-xml.ftl template.
Corrected pf_Rogue.xml result: +1 reflex comes from Halfling Luch and +3 from his Cloak.
…actions" Created a "graceful exit" object + interceptor. It is supposed to replace System.Exit calls in different parts of the project; Updated reporting.gradle by increasing versions of some dependencies; Removed a DM_EXIT rule from spotbugs -> the calls of System.Exit must be replaced with GracefulExit. The decision to create a custom interceptor was taken based on the discussion from Reddit: https://www.reddit.com/r/java/comments/1fpxmfp/jep_486_permanently_disable_the_security_manager/
Signed-off-by: Vest <Vest@users.noreply.github.com>
Added the same task to plugins.gradle Signed-off-by: Vest <Vest@users.noreply.github.com>
Removed the `buildNsis` task from the Gradle `test_script`, streamlining the build process. Additionally, fixed unnecessary trailing spaces in multiple sections for better formatting consistency. These changes simplify the CI process and improve readability. Signed-off-by: Vest <Vest@users.noreply.github.com>
This commit deletes `build-gradle.xml` and `pluginbuild.xml` as they are no longer required. The transition to a Gradle-based build system eliminates dependency on Ant, simplifying the build process. Signed-off-by: Vest <Vest@users.noreply.github.com>
Added a new warning message for remote list preferences in properties. Improved Gradle tasks to include all nested class files for export and bonus plugins, ensuring more comprehensive builds. Signed-off-by: Vest <Vest@users.noreply.github.com>
…ethod signatures in PCGenTaskExecutor and PluginLoader Signed-off-by: Vest <Vest@users.noreply.github.com>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <Vest@users.noreply.github.com>
…n``` Few recent pull requests broke the styling: PCGen#7319 Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
…lows Signed-off-by: Vest <Vest@users.noreply.github.com>
# Conflicts: # build.gradle
…n in wrapper scripts Signed-off-by: Vest <Vest@users.noreply.github.com>
… with new tests Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
…test classes Signed-off-by: Vest <Vest@users.noreply.github.com>
…sponding .java files. The slow test has been reverted, because it was broken in old commits (DATA-4372) Signed-off-by: Vest <Vest@users.noreply.github.com>
# Conflicts: # build.gradle
Gradle wrapper to 9.1.0 Signed-off-by: Vest <Vest@users.noreply.github.com>
# Conflicts: # code/src/java/pcgen/core/PlayerCharacter.java # code/src/java/pcgen/io/ExportHandler.java
…ations to avoid Gradle's warnings. Such constructions will be deprecated in Gradle 10. Signed-off-by: Vest <Vest@users.noreply.github.com>
…radle Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
…lity class Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
Signed-off-by: Vest <Vest@users.noreply.github.com>
Added many rules to ruleset.xml Fixed few warnings Enabled config-cache for testing purposes. Signed-off-by: Vest <Vest@users.noreply.github.com>
# Conflicts: # build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.