fix(j0di3): Validate troopId UUID format before proxying (closes #1066)#1113
Open
jeromehardaway wants to merge 1 commit into
Open
fix(j0di3): Validate troopId UUID format before proxying (closes #1066)#1113jeromehardaway wants to merge 1 commit into
jeromehardaway wants to merge 1 commit into
Conversation
Closes #1066. J0dI3 issues UUIDs for troop IDs in ensure-troop.ts, but j0di3-proxy only checked truthiness. A stale session or botched migration could let a malformed value through and surface to the user as an opaque 4xx/5xx from the backend. The proxy now rejects anything that doesn't match the UUID shape with a 400 and a clear "sign out and back in" message, and logs the redacted value so we can investigate how it got there. Existing fixture switched to a real UUID and a new test covers the rejection path.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1066.
Test plan