feat(career-guides): Add Marine Corps MOS 6333 Aviation Electronics Tech#1164
Open
jeromehardaway wants to merge 1 commit into
Open
feat(career-guides): Add Marine Corps MOS 6333 Aviation Electronics Tech#1164jeromehardaway wants to merge 1 commit into
jeromehardaway wants to merge 1 commit into
Conversation
The training-pipeline key 6333 is occupied by the Navy officer designator (Aviation Maintenance Officer), so the Marine Corps MOS 6333 was missing from the Career Guide. Add it under the branch-prefixed key marine_corps:6333 with a technician-flavored career-pathways entry covering avionics and software-adjacent roles. The guide loader now prefers an exact full-key pathway lookup before the bare code so each 6333 entry resolves its own pathway data, and each guide carries a slug (the full training key) so the two entries link to distinct detail pages. The detail route strips the branch prefix for display.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Marine Corps MOS 6333 (Aviation Electronics Technician) was missing from the Career Guide. The
training-pipeline.jsonkey"6333"is occupied by the Navy officer designator 6333 (Aviation Maintenance Officer), so the Marine MOS could not be added under its bare code. The resume-translator data (job-codes-index.json,job-codes-descriptions.json) already covers both branches; the gap was Career Guide data only. Closes #1124.Solution
src/data/training-pipeline.json— added"marine_corps:6333"(Marine Corps, Aviation Electronics Technician, CNATT NAS Pensacola program, avionics/electrical topics incl. fault isolation, wiring schematics, MIL-SPEC standards, test equipment), modeled on the existing Marine avionics entry"6316".loadCareerGuides()already strips branch prefixes from keys, so this yields a second 6333 guide entry with the correct branch.src/data/career-pathways-map.json— the existing bare"6333"pathways entry is officer/management flavored (Aircraft Maintenance Manager, QA Specialist, Logistics Manager), so a shared entry would misrepresent the technician MOS. Added"marine_corps:6333"with technician-flavored roles: Avionics Technician plus the software-adjacent targets named in the issue (Junior Software Engineer, Software Developer in Test, Systems Software Developer, DevOps Engineer).src/lib/career-guides.ts— pathway lookup now prefers the exact full key before the bare code (pathways[key] ?? pathways[code] ?? ...), so each 6333 entry resolves its own pathway data. Each guide also gets aslug(full training key, lowercased) sincecodeis no longer unique.src/containers/career-guides/{types.ts,grid-view.tsx}—GuideEntry.slugadded; guide cards link by slug, so the two 6333 cards lead to distinct detail pages.src/pages/career-guides/[mos].tsx— the detail route already resolves branch-prefixed keys via its existing key-matching fallback (/career-guides/marine_corps:6333→ Marine guide;/career-guides/6333deterministically remains the Navy entry, the only bare-key match). Added a strip of the branch prefix for the displayed code so the page shows6333, notMARINE_CORPS:6333.__tests__/lib/career-guides.test.ts— new tests: two 6333 entries with correct branch/title/rank/slug, each resolving its own pathway data (Navy → Aircraft Maintenance Manager, Marine → Avionics Technician), and slug uniqueness across all guides.Both edited JSON files were inserted textually next to their sibling entries and re-validated with
node(JSON.parseviarequire).Limitations
/career-guides/marine_corps:6333. Its JSON-LDurlfield is derived from the bare display code and therefore points at/career-guides/6333; threading the slug into the page component for structured data was left out to keep the change minimal.cert-equivalencies.json,military-systems-map.json,cognitive-skills-map.json, andtech-pathways-map.jsonhave nomarine_corps:6333entries, so those detail-page sections fall back to their existing empty defaults. They can be backfilled by thegenerate:*scripts later.Verification
npm run typecheck— 7 pre-existing errors in__tests__/{lib,pages/api}/j0di3/*(verified identical count on clean master via stash); no new errors.npm run lint— 25 errors / 491 warnings, all pre-existing in untouched files;npx biome checkon the changed files reports 0 errors (1 pre-existing complexity warning ondetectRank, untouched by this PR).npm test— 42 files, 387 tests, all pass (includes 3 new tests).npm run build— succeeds (swagger spec, Next build, sitemap).