Skip to content

fix(ui): Surface fetch errors instead of swallowing them #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeromehardaway merged 5 commits into from
Jun 22, 2026
Merged

fix(ui): Surface fetch errors instead of swallowing them #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
088ff22
fix(ui): Surface fetch errors instead of swallowing them
jeromehardaway Jun 11, 2026
ffbd69c
fix(community): Surface non-OK candidate fetches instead of empty UI
jeromehardaway Jun 22, 2026
fc351d3
fix(profile): Label select, add backdrop prefix, drop repo animation
jeromehardaway Jun 22, 2026
f103c49
Merge remote-tracking branch 'origin/master' into fix/1058-silent-cat…
jeromehardaway Jun 22, 2026
36cc84e
chore: Re-sync branch with master to refresh merge status
jeromehardaway Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
236 changes: 170 additions & 66 deletions __tests__/pages/challenges/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { render, screen, fireEvent, waitFor } from "@testing-library/react";
import { fireEvent, render, screen, waitFor } from "@testing-library/react";

// Mock next/router
vi.mock("next/router", () => ({
Expand All @@ -23,6 +23,7 @@ vi.mock("@/lib/challenge-runner", () => ({
}));

import { runChallenge } from "@/lib/challenge-runner";

const mockRunChallenge = vi.mocked(runChallenge);

const mockFetch = vi.fn();
Expand Down Expand Up @@ -103,15 +104,16 @@ describe("ChallengesPage", () => {
if (url.includes("start") && opts?.method === "POST") {
return Promise.resolve({
ok: true,
json: () => Promise.resolve({
id: "ch-1",
title: "FizzBuzz",
description: "Write a FizzBuzz function",
topic: "javascript",
difficulty: "easy",
language: "javascript",
starter_code: "function fizzBuzz(n) {\n // your code\n}",
}),
json: () =>
Promise.resolve({
id: "ch-1",
title: "FizzBuzz",
description: "Write a FizzBuzz function",
topic: "javascript",
difficulty: "easy",
language: "javascript",
starter_code: "function fizzBuzz(n) {\n // your code\n}",
}),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
Expand Down Expand Up @@ -155,27 +157,29 @@ describe("ChallengesPage", () => {
if (url.includes("start") && opts?.method === "POST") {
return Promise.resolve({
ok: true,
json: () => Promise.resolve({
id: "ch-2",
title: "Sum Array",
description: "Sum all elements",
topic: "javascript",
difficulty: "easy",
language: "javascript",
test_cases: [
{ input: "[1, 2, 3]", expected_output: "6", hidden: false },
],
}),
json: () =>
Promise.resolve({
id: "ch-2",
title: "Sum Array",
description: "Sum all elements",
topic: "javascript",
difficulty: "easy",
language: "javascript",
test_cases: [
{ input: "[1, 2, 3]", expected_output: "6", hidden: false },
],
}),
});
}
if (url.includes("submit") && opts?.method === "POST") {
return Promise.resolve({
ok: true,
json: () => Promise.resolve({
passed: true,
score: 100,
feedback: "Perfect solution!",
}),
json: () =>
Promise.resolve({
passed: true,
score: 100,
feedback: "Perfect solution!",
}),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
Expand All @@ -200,8 +204,8 @@ describe("ChallengesPage", () => {
});

// The submit POST must include the runner's structured client_results.
const submitCall = mockFetch.mock.calls.find(([url, opts]) =>
String(url).includes("submit") && opts?.method === "POST"
const submitCall = mockFetch.mock.calls.find(
([url, opts]) => String(url).includes("submit") && opts?.method === "POST"
);
expect(submitCall).toBeDefined();
const body = JSON.parse(submitCall![1].body);
Expand All @@ -215,16 +219,17 @@ describe("ChallengesPage", () => {
if (url.includes("recommended")) {
return Promise.resolve({
ok: true,
json: () => Promise.resolve([
{
id: "rec-1",
title: "Binary Search",
description: "Implement binary search",
topic: "algorithms",
difficulty: "medium",
language: "javascript",
},
]),
json: () =>
Promise.resolve([
{
id: "rec-1",
title: "Binary Search",
description: "Implement binary search",
topic: "algorithms",
difficulty: "medium",
language: "javascript",
},
]),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
Expand All @@ -244,26 +249,27 @@ describe("ChallengesPage", () => {
if (url.includes("history")) {
return Promise.resolve({
ok: true,
json: () => Promise.resolve([
{
id: "att-1",
challenge_id: "ch-1",
title: "Two Sum",
topic: "arrays",
difficulty: "easy",
passed: true,
submitted_at: "2026-04-01T10:00:00Z",
},
{
id: "att-2",
challenge_id: "ch-2",
title: "Merge Sort",
topic: "algorithms",
difficulty: "hard",
passed: false,
submitted_at: "2026-04-02T10:00:00Z",
},
]),
json: () =>
Promise.resolve([
{
id: "att-1",
challenge_id: "ch-1",
title: "Two Sum",
topic: "arrays",
difficulty: "easy",
passed: true,
submitted_at: "2026-04-01T10:00:00Z",
},
{
id: "att-2",
challenge_id: "ch-2",
title: "Merge Sort",
topic: "algorithms",
difficulty: "hard",
passed: false,
submitted_at: "2026-04-02T10:00:00Z",
},
]),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
Expand Down Expand Up @@ -297,19 +303,117 @@ describe("ChallengesPage", () => {
});
});

it("shows an error with retry when the recommended fetch rejects", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
mockFetch.mockImplementation((url: string) => {
if (url.includes("recommended")) {
return Promise.reject(new TypeError("Failed to fetch"));
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
});

render(<ChallengesPage />);

await waitFor(() => {
expect(screen.getByText("Failed to fetch")).toBeInTheDocument();
});
expect(screen.getByText("Retry")).toBeInTheDocument();

// Retry refetches and renders the recovered list
mockFetch.mockImplementation((url: string) => {
if (url.includes("recommended")) {
return Promise.resolve({
ok: true,
json: () =>
Promise.resolve([
{
id: "rec-1",
title: "Binary Search",
topic: "algorithms",
difficulty: "medium",
},
]),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
});

fireEvent.click(screen.getByText("Retry"));

await waitFor(() => {
expect(screen.getByText("Binary Search")).toBeInTheDocument();
});
consoleSpy.mockRestore();
});

it("shows an error when the history request returns non-ok", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
mockFetch.mockImplementation((url: string) => {
if (url.includes("history")) {
return Promise.resolve({ ok: false, json: () => Promise.resolve({}) });
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
});

render(<ChallengesPage />);

await waitFor(() => {
expect(screen.getByText("Failed to load your history")).toBeInTheDocument();
});
consoleSpy.mockRestore();
});

it("surfaces an error when fetching a hint fails", async () => {
const consoleSpy = vi.spyOn(console, "error").mockImplementation(() => {});
mockFetch.mockImplementation((url: string, opts?: any) => {
if (url.includes("start") && opts?.method === "POST") {
return Promise.resolve({
ok: true,
json: () =>
Promise.resolve({
id: "ch-1",
title: "Test",
description: "Test desc",
topic: "js",
difficulty: "easy",
language: "javascript",
}),
});
}
if (url.includes("hint")) {
return Promise.reject(new TypeError("Failed to fetch"));
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
});

render(<ChallengesPage />);

fireEvent.click(screen.getByText("Start Challenge"));

await waitFor(() => screen.getByText("Test"));

fireEvent.click(screen.getByText("Get Hint (0 used)"));

await waitFor(() => {
expect(screen.getByText("Failed to fetch")).toBeInTheDocument();
});
consoleSpy.mockRestore();
});

it("navigates back from active challenge", async () => {
mockFetch.mockImplementation((url: string, opts?: any) => {
if (url.includes("start") && opts?.method === "POST") {
return Promise.resolve({
ok: true,
json: () => Promise.resolve({
id: "ch-1",
title: "Test",
description: "Test desc",
topic: "js",
difficulty: "easy",
language: "javascript",
}),
json: () =>
Promise.resolve({
id: "ch-1",
title: "Test",
description: "Test desc",
topic: "js",
difficulty: "easy",
language: "javascript",
}),
});
}
return Promise.resolve({ ok: true, json: () => Promise.resolve([]) });
Expand Down
1 change: 1 addition & 0 deletions src/assets/css/globals.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@
NAVIGATION UPGRADE — Premium styling
============================================= */
.header-inner {
-webkit-backdrop-filter: blur(12px);
backdrop-filter: blur(12px);
}

Expand Down
10 changes: 3 additions & 7 deletions src/components/profile/RepositoryShowcase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { motion } from "motion/react";
import { useState } from "react";
import type { GitHubRepo } from "@/types/profile";
import { GITHUB_LANGUAGE_COLORS } from "@/types/profile";
Expand Down Expand Up @@ -85,15 +84,12 @@ const RepositoryShowcase = ({ repos, isLoading }: RepositoryShowcaseProps) => {

{/* Repo list */}
<div className="tw-grid tw-gap-4 md:tw-grid-cols-2">
{sorted.map((repo, i) => (
<motion.a
{sorted.map((repo) => (
<a
key={repo.id}
href={repo.html_url}
target="_blank"
rel="noopener noreferrer"
initial={{ opacity: 0, y: 10 }}
animate={{ opacity: 1, y: 0 }}
transition={{ duration: 0.3, delay: i * 0.05 }}
className="tw-block tw-rounded-lg tw-border tw-border-navy/10 tw-bg-white tw-p-5 tw-shadow-sm tw-transition-all hover:tw-border-gold/30 hover:tw-shadow-md hover:-tw-translate-y-0.5"
>
<div className="tw-flex tw-items-start tw-justify-between">
Expand Down Expand Up @@ -142,7 +138,7 @@ const RepositoryShowcase = ({ repos, isLoading }: RepositoryShowcaseProps) => {
</span>
))}
</div>
</motion.a>
</a>
))}
</div>
</div>
Expand Down
Loading
Loading