Implement Prisma & Neon by jonulak · Pull Request #747 · Vets-Who-Code/vets-who-code-app

jonulak · 2025-06-09T17:25:24Z

Pull Request Description

Summary:

This pull request introduces Prisma integration into the NextAuth authentication framework within the Vets Who Code app. Prisma will now handle user authentication and session management, enhancing security and performance across the platform.

Changes Made:

Integrated Prisma ORM for user authentication and session management data persistence.
Configured NextAuth to use Prisma models for user data storage and retrieval.

Required Changes

Addition of environment variable DATABASE_URL for Neon config
Creation of dev/preview branch specific Github OAuth app
Connect Neon & Vercel for database branching for preview deployments
Automated Prisma model migration for preview branches & merging

Resolves #734
Resolves #647

vercel · 2025-06-09T17:25:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vets-who-code-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 18, 2025 4:21pm

github-actions · 2025-06-09T17:36:25Z

🔍 Code Quality Score Breakdown:

📖 Readability: 4/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.5/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

github-actions · 2025-06-09T17:44:01Z

🔍 Code Quality Score Breakdown:

📖 Readability: 4/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.5/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

github-actions · 2025-06-09T17:45:51Z

🔍 Code Quality Score Breakdown:

📖 Readability: 4/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.5/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

Copilot

Pull Request Overview

This PR integrates Prisma with Neon into NextAuth for user authentication and session management in the Vets Who Code app.

Configures Prisma ORM and Neon serverless adapter using DATABASE_URL
Refactors NextAuth settings into a shared options.ts module with the Prisma adapter
Adds Prisma schema and initial migrations for authentication models

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/pages/auth/error.tsx	Adjusted layout props, error lookup normalization, and styling
src/pages/api/auth/options.ts	Defined NextAuth options with PrismaAdapter and GitHub callbacks
src/pages/api/auth/[...nextauth].ts	Simplified API entrypoint to use shared `options`
src/lib/prisma.ts	Initialized PrismaClient with Neon adapter and dev persistence
prisma/schema.prisma	Added models for User, Account, Session, VerificationToken, etc.
prisma/migrations/*	Included lock file and initial SQL migration for new models
package.json	Added Prisma, Neon, NextAuth Prisma adapter, bumped dependencies
.nvmrc	Updated Node version to v20

Comments suppressed due to low confidence (5)

src/pages/auth/error.tsx:60

Making Layout required may break pages that omit it. Consider keeping it optional or ensuring all pages define a Layout property.

    Layout: typeof Layout;

src/pages/auth/error.tsx:91

[nitpick] Reducing the container height from full viewport to 75vh may cause unexpected whitespace on smaller screens; please verify this aligns with the design.

<div className="tw-sm:px-6 tw-lg:px-8 tw-flex tw-min-h-[75vh] tw-flex-col tw-justify-center tw-bg-gray-50 tw-py-12">

src/pages/auth/error.tsx:132

The tw-text-secondary utility may not be defined in the Tailwind config. Ensure this color token exists or revert to a standard gray shade.

<p className="tw-text-sm tw-text-secondary">

src/lib/prisma.ts:9

If DATABASE_URL is undefined, the connection string becomes the literal "undefined". It’s safer to validate the env var and throw an error if missing.

const connectionString = `${process.env.DATABASE_URL}`;

.nvmrc:1

[nitpick] The version format changed from a plain number to a v-prefixed string. For consistency with other projects, consider using 20 or 20.0.0 without the v prefix.

v20

Copilot · 2025-06-11T01:52:32Z

+        if (errorType && errorMessages[errorType.toLowerCase()]) {
+            setError(errorMessages[errorType.toLowerCase()]);


Calling toLowerCase() twice is redundant. Extract errorType.toLowerCase() to a variable for clarity and performance.

Suggested change

if (errorType && errorMessages[errorType.toLowerCase()]) {

setError(errorMessages[errorType.toLowerCase()]);

if (errorType) {

const normalizedErrorType = errorType.toLowerCase();

if (errorMessages[normalizedErrorType]) {

setError(errorMessages[normalizedErrorType]);

}

@jonulak you review this?

Added in 2844ee1

Copilot · 2025-06-11T01:52:33Z

+                        },
+                        5000 // 5 second timeout
+                    );
+                    console.log(JSON.stringify(res.status));


Using JSON.stringify on a numeric status is unnecessary. Consider console.log(res.status) for simplicity.

Suggested change

console.log(JSON.stringify(res.status));

console.log(res.status);

github-actions · 2025-06-13T00:03:16Z

🔍 Code Quality Score Breakdown:

📖 Readability: 5/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.8/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

github-actions · 2025-06-17T16:27:22Z

🔍 Code Quality Score Breakdown:

📖 Readability: 5/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.8/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

commit b56e409 Author: Jerome Hardaway <jerome@vetswhocode.io> Date: Tue Jun 17 18:24:35 2025 -0400 Refactor: Replace Section component imports with EngagementModal in various containers (#781) - Updated imports in blog, brand, contact, course, cta, donate, event, faq, funfact, gradation, newsletter, profile, quote, register-guide, service, team, testimonial, timeline, video, and zoom-meetings containers to use EngagementModal instead of the previous Section component. - Added EngagementModal component with custom animations and accessibility features. - Introduced EngagementModal styles for improved UI/UX. commit bc3c9d2 Author: Jerome Hardaway <jerome@vetswhocode.io> Date: Tue Jun 17 13:22:46 2025 -0400 refactor: remove unused EngagementModal component and associated animations commit 8add330 Author: Jerome Hardaway <jerome@vetswhocode.io> Date: Tue Jun 17 08:44:42 2025 -0400 Add Engagement Modal with custom animations and accessibility features (#780) - Implemented EngagementModal component with props for headline, body, and call-to-action buttons. - Added custom CSS animations for emoji wiggle effect on button hover. - Integrated Framer Motion for smooth modal transitions. - Included accessibility features such as focus trapping and ESC key close functionality. - Added session storage logic to prevent multiple modal displays in a session. - Provided a development-only button to test modal functionality. commit e4c58e6 Author: Jerome Hardaway <jerome@vetswhocode.io> Date: Wed Jun 11 18:44:26 2025 -0400 refactor: streamline request body validation and Slack message formatting

github-actions · 2025-06-18T16:18:31Z

🔍 Code Quality Score Breakdown:

📖 Readability: 5/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.8/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

jonulak · 2025-06-18T16:25:16Z

@jeromehardaway Changes from master are merged in, ready for review

github-actions · 2025-06-19T16:09:51Z

🔍 Code Quality Score Breakdown:

📖 Readability: 5/10
📈 Scalability: 5/10
🚀 Performance: 5/10
🛠️ Maintainability: 8/10
✅ Overall Score: 5.8/10

💡 Recommendations:

🧹 Reduce ESLint warnings to improve readability.
📦 Break up complex functions or components.
⚙️ Consider splitting large files or lazy-loading.
🔁 Refactor to increase your overall score next cycle.

jonulak added 2 commits June 9, 2025 13:00

Integrate next-auth with prisma ORM

2a8321f

Merge from main

e9e6dfe

Merge branch 'master' into jonulak/implement-neon-db

5ef8e30

vercel Bot had a problem deploying to Preview June 9, 2025 17:36 Failure

Update .nvmrc version

33b6a4a

vercel Bot had a problem deploying to Preview June 9, 2025 17:43 Failure

Update nvmrc for jest compatibility

c515fd1

vercel Bot deployed to Preview June 9, 2025 17:45 View deployment

jonulak linked an issue Jun 9, 2025 that may be closed by this pull request

Attach Neon Databases To Web App #647

Closed

jeromehardaway requested review from Copilot and jeromehardaway June 11, 2025 01:50

jeromehardaway assigned jeromehardaway and jonulak Jun 11, 2025

Copilot AI reviewed Jun 11, 2025

View reviewed changes

Add postinstall script for prisma client generation

d6783b9

vercel Bot deployed to Preview June 13, 2025 00:04 View deployment

Add prisma deploy & add copilot suggestions

2844ee1

vercel Bot deployed to Preview June 17, 2025 16:22 View deployment

Update build script for test compatibility

4cacb62

vercel Bot deployed to Preview June 17, 2025 16:28 View deployment

jonulak marked this pull request as ready for review June 17, 2025 16:33

vercel Bot deployed to Preview June 18, 2025 16:21 View deployment

jonulak assigned jonulak and unassigned jonulak Jun 19, 2025

jonulak closed this Jun 19, 2025

jonulak reopened this Jun 19, 2025

jeromehardaway approved these changes Jun 19, 2025

View reviewed changes

jonulak merged commit 1871c93 into master Jun 20, 2025
8 checks passed

jonulak deleted the jonulak/implement-neon-db branch June 20, 2025 20:09

		if (errorType && errorMessages[errorType.toLowerCase()]) {
		setError(errorMessages[errorType.toLowerCase()]);

-        if (errorType && errorMessages[errorType.toLowerCase()]) {
-            setError(errorMessages[errorType.toLowerCase()]);
+        if (errorType) {
+            const normalizedErrorType = errorType.toLowerCase();
+            if (errorMessages[normalizedErrorType]) {
+                setError(errorMessages[normalizedErrorType]);
+            }

	console.log(JSON.stringify(res.status));
	console.log(res.status);

Uh oh!

Uh oh!

Conversation

jonulak commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary:

Changes Made:

Required Changes

Uh oh!

vercel Bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

jeromehardaway Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

jonulak Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 13, 2025

Uh oh!

github-actions Bot commented Jun 17, 2025

Uh oh!

github-actions Bot commented Jun 18, 2025

Uh oh!

jonulak commented Jun 18, 2025

Uh oh!

github-actions Bot commented Jun 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonulak commented Jun 9, 2025 •

edited

Loading

vercel Bot commented Jun 9, 2025 •

edited

Loading