Skip to content

Fixes required flags for ikwid on codex#50

Merged
nezhar merged 1 commit into
mainfrom
fix-codex
Mar 21, 2026
Merged

Fixes required flags for ikwid on codex#50
nezhar merged 1 commit into
mainfrom
fix-codex

Conversation

@nezhar
Copy link
Copy Markdown
Collaborator

@nezhar nezhar commented Mar 20, 2026

This pull request updates the way the codex agent is configured and tested by replacing the --full-auto argument with a more explicit and potentially less restrictive --dangerously-bypass-approvals-and-sandbox argument. All related tests and documentation strings have been updated to reflect this change.

Agent configuration update:

  • Changed the ikwid_args for the codex agent in AgentSpec from ["--full-auto"] to ["--dangerously-bypass-approvals-and-sandbox"] to alter the agent's startup behavior.

Testing updates:

  • Updated the assertion in test_codex_spec_has_ikwid_args to expect the new argument for the codex agent.
  • Updated the docstring in test_ikwid_appends_args_for_codex and the corresponding command assertion to reflect the new argument. [1] [2]

Summary by CodeRabbit

  • Chores
    • Updated codex agent configuration parameters to reflect new operational settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 796e13bd-484b-4248-b105-277660528231

📥 Commits

Reviewing files that changed from the base of the PR and between 18cb3c0 and 33fa57e.

📒 Files selected for processing (3)
  • src/vibepod/core/agents.py
  • tests/test_agents.py
  • tests/test_run.py

📝 Walkthrough

Walkthrough

The codex agent specification's ikwid_args parameter is updated from ["--full-auto"] to ["--dangerously-bypass-approvals-and-sandbox"] in the agent definition file. Corresponding test assertions are updated to reflect this new expected value. No control flow or functional logic is altered.

Changes

Cohort / File(s) Summary
Core Agent Specification
src/vibepod/core/agents.py
Updated codex agent's ikwid_args from ["--full-auto"] to ["--dangerously-bypass-approvals-and-sandbox"].
Test Updates
tests/test_agents.py, tests/test_run.py
Updated expected ikwid_args assertion in agent spec test and --ikwid command-line argument injection test to match the new parameter value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 The codex hops with newfound might,
Bypassing guards with sandboxes bright,
No more the auto-full charade,
Dangerous paths now clearly made! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the ikwid flags for the codex agent.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-codex
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Trivy to scan for security misconfigurations and secrets in Infrastructure as Code files.

Add a .trivyignore file to your project to customize which findings Trivy reports.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Mar 20, 2026

Greptile Summary

This PR replaces the --full-auto flag with --dangerously-bypass-approvals-and-sandbox for the codex agent's ikwid_args, reflecting a change in the upstream codex CLI's required flags for unattended/fully-automated runs. All three touched files are updated consistently: the agent spec, the spec-level unit test, and the integration-level run test (both the assertion and the docstring).

  • The change is a one-for-one flag substitution with no structural or behavioral logic changes beyond the flag name itself.
  • No stale references to --full-auto remain anywhere in the codebase (docs, source, or tests).
  • The new flag name (--dangerously-bypass-approvals-and-sandbox) is more descriptive and aligns with how it behaves in the codex CLI.
  • No new edge cases or error paths are introduced.

Confidence Score: 5/5

  • This PR is safe to merge — it is a minimal, self-consistent flag rename with all test assertions updated.
  • The change is a single-line flag replacement in the agent spec and two corresponding test updates. All occurrences of --full-auto have been removed, all references to --dangerously-bypass-approvals-and-sandbox are consistent, documentation files do not reference either flag directly, and the surrounding logic in run.py is untouched.
  • No files require special attention.

Important Files Changed

Filename Overview
src/vibepod/core/agents.py Updates codex agent's ikwid_args from --full-auto to --dangerously-bypass-approvals-and-sandbox; no logic changes, straightforward flag replacement.
tests/test_agents.py Updates the expected value in test_codex_spec_has_ikwid_args to match the new --dangerously-bypass-approvals-and-sandbox argument; fully aligned with the source change.
tests/test_run.py Updates docstring and command assertion in test_ikwid_appends_args_for_codex to reflect the new flag; tests remain complete and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["vp run codex --ikwid"] --> B{"spec.ikwid_args\nis set?"}
    B -- Yes --> C["Append ikwid_args to command\n--dangerously-bypass-approvals-and-sandbox"]
    B -- No --> D["Log warning, proceed\nwith unmodified command"]
    C --> E["Docker: run_agent(command=['codex',\n'--dangerously-bypass-approvals-and-sandbox'])"]
    D --> F["Docker: run_agent(command=['codex'])"]
Loading

Last reviewed commit: "Fixes required flags..."

@nezhar nezhar merged commit a9863de into main Mar 21, 2026
20 checks passed
@nezhar nezhar deleted the fix-codex branch April 10, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant