Fixes gemini cli start issues#52
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughUpdated documentation image namespaces to Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as "vibepod CLI"
participant Run as "commands.run.run()"
participant Env as "_terminal_env_defaults()"
participant Docker as "DockerManager.run_agent()"
participant Container as "Container (running)"
CLI->>Run: invoke run(...) with agent spec and --env
Run->>Env: collect terminal env defaults
Env-->>Run: terminal env dict
Run->>Run: merge USER_UID/USER_GID, spec.extra_env, CLI --env, terminal env
Run->>Docker: run_agent(..., env=merged_env, command=agent.command)
Docker-->>Container: start container with merged env and command
Container-->>CLI: container running / outputs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes Gemini CLI startup issues by switching its container command from the bare Confidence Score: 5/5Safe to merge — all logic changes are well-tested and the only finding is a non-blocking style suggestion around test helper duplication. All three functional concerns (gemini command, image namespace, terminal env) are covered by new tests; the env priority ordering is correct (terminal defaults < spec.extra_env < agent config < CLI flags); no regressions introduced in existing tests. No files require special attention; tests/test_run.py has minor code duplication but no correctness issues. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["run() called"] --> B["Build merged_env"]
B --> B1["USER_UID / USER_GID"]
B1 --> B2["_terminal_env_defaults()\n(TERM, COLORTERM, TERM_PROGRAM,\nTERM_PROGRAM_VERSION, LANG)\n+ TERM default xterm-256color"]
B2 --> B3["spec.extra_env\n(e.g. HOME=/config for gemini)"]
B3 --> B4["agent_cfg env\n(from vibepod config file)"]
B4 --> B5["--env CLI flags\n(highest priority)"]
B5 --> C["Resolve command"]
C --> D{Agent == gemini?}
D -- Yes --> E["['env', 'HOME=/config',\n'node', '/usr/local/bin/gemini']"]
D -- No --> F["spec.command\n(e.g. ['claude'], ['codex'], ...)"]
E --> G["DockerManager.run_agent()"]
F --> G
Reviews (1): Last reviewed commit: "Fixes gemini cli start issues" | Re-trigger Greptile |
This pull request updates the default Docker images for several agents to use the official
vibepodnamespace, improves how the Gemini agent is launched, and enhances environment variable handling for interactive containers. It also adds new tests to ensure these changes work as expected.Summary by CodeRabbit
New Features
Updates
Tests