Skip to content

Add ikwid options for pi agent#82

Merged
nezhar merged 1 commit into
mainfrom
pi-ikwid-mode
Jun 10, 2026
Merged

Add ikwid options for pi agent#82
nezhar merged 1 commit into
mainfrom
pi-ikwid-mode

Conversation

@nezhar

@nezhar nezhar commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Adds support for the Pi agent's auto-approval (trust) mode by introducing the --approve flag, updating both documentation and code to reflect this new capability. It also includes tests to ensure the correct behavior and updates references to the Pi agent's trust system.

Code changes:

  • Added ikwid_args=["--approve"] to the Pi agent's AgentSpec in src/vibepod/core/agents.py, enabling the flag when running in IKWID mode.

Based on earendil-works/pi#5514 and earendil-works/pi#5549

Summary by CodeRabbit

  • Documentation

    • Added comprehensive documentation for the Pi agent's per-project trust/approval system, including interactive prompts and non-interactive configuration modes with customizable defaults.
  • New Features

    • Pi agent now includes automatic approval support for IKWID mode operations.

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f4a9e14-4867-42e2-9f72-19bb8a83d34b

📥 Commits

Reviewing files that changed from the base of the PR and between c59da96 and c6f8d04.

📒 Files selected for processing (4)
  • README.md
  • docs/agents/index.md
  • src/vibepod/core/agents.py
  • tests/test_agents.py

📝 Walkthrough

Walkthrough

This PR adds explicit IKWID auto-approval support to the Pi agent by setting ikwid_args=["--approve"] in its configuration, documenting the associated per-project trust system, and updating test assertions to reflect the change.

Changes

Pi Agent IKWID Support

Layer / File(s) Summary
Pi agent configuration and test validation
src/vibepod/core/agents.py, tests/test_agents.py
The Pi agent's AgentSpec adds ikwid_args=["--approve"] to enable non-interactive approval. Tests validate the configuration and exclude Pi from the unsupported agents list.
Pi agent documentation and table updates
docs/agents/index.md, README.md
IKWID mode documentation is expanded for the Pi agent, describing the trust/approval flow (/trusttrust.json), how --ikwid appends --approve, and how non-interactive modes use defaultProjectTrust without prompting. Table entries are reordered to list Pi first.
Gemini agent test coverage
tests/test_agents.py
New test validates that the Gemini agent spec uses an env/node wrapper command with proper paths and environment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • VibePod/vibepod-cli#47: Both PRs extend the --ikwid auto-approval mechanism by adding and validating AgentSpec.ikwid_args configuration.
  • VibePod/vibepod-cli#54: Main PR extends --ikwid by adding ikwid_args=["--approve"] for the Pi agent, directly aligned with per-agent --ikwid argument injection and test coverage.
  • VibePod/vibepod-cli#76: The retrieved PR adds the Pi agent without ikwid_args, while the main PR now sets ikwid_args=["--approve"] and updates tests and documentation accordingly.

Poem

🐰 The Pi agent hops forth with approval in tow,
No prompts to delay the trust's steady flow,
With --ikwid and --approve locked in place,
Your projects run free at a trust-driven pace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding IKWID options (--approve flag) for the pi agent across code, documentation, and tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pi-ikwid-mode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@augmentcode

augmentcode Bot commented Jun 10, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Adds Pi agent support for IKWID auto-approval by appending --approve when vp run --ikwid is used.

Changes: Updates the Pi AgentSpec, refreshes README/docs, and adds a unit test to verify the new ikwid_args behavior.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@nezhar nezhar merged commit 36942cd into main Jun 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant