feat(commands): add delete row/column keybindings

Register two new command-palette entries with editable default
keybindings, mirroring the existing insert/move command structure:

- Markdown table: delete row — default Ctrl+Backspace
- Markdown table: delete column — default Ctrl+Delete

Both operate on the focused cell, guard against deleting the header
row or the last remaining row/column, and stash a pendingToolbar
entry on the neighbouring cell so the pinned toolbar and caret
follow after re-render.

Author: VictorVow

src/index.js

@@ -3,7 +3,7 @@ import '@logseq/libs'
 import parseMarkdownTable from './utils/parseRawInputByMarkdownIt'
 import { splitStrByTable } from './utils/splitStrByTable'
 import { looksLikeMarkdownTable, markdownTableToMatrix } from './utils/detectMarkdownTable'
-import { attachInlineEditing, insertInFocusedTableCell, moveCaretInFocusedTableCell, moveInFocusedTableCell, prepareInlineRenderer, resumePinnedToolbar } from './utils/inlineEditable'
+import { attachInlineEditing, deleteInFocusedTableCell, insertInFocusedTableCell, moveCaretInFocusedTableCell, moveInFocusedTableCell, prepareInlineRenderer, resumePinnedToolbar } from './utils/inlineEditable'
 import i18n from './locales/i18n'
 import './index.css'
 
@@ -170,6 +170,20 @@ if (isInBrowser) {
         keybinding: { binding: 'ctrl+alt+shift+left' }
       }, () => insertInFocusedTableCell('colLeft'))
 
+      // Row/column delete. No local keydown handler covers these — the
+      // bindings below are the only way to trigger them via keyboard
+      // (besides the right-click menu / pinned toolbar).
+      logseq.App.registerCommandPalette({
+        key: 'mdtable-delete-row',
+        label: i18n.t('Markdown table: delete row'),
+        keybinding: { binding: 'ctrl+backspace' }
+      }, () => deleteInFocusedTableCell('row'))
+      logseq.App.registerCommandPalette({
+        key: 'mdtable-delete-col',
+        label: i18n.t('Markdown table: delete column'),
+        keybinding: { binding: 'ctrl+delete' }
+      }, () => deleteInFocusedTableCell('col'))
+
       // Row/column move. Defaults match the local Alt+Shift+Arrow handler
       // in `attachInlineEditing`.
       logseq.App.registerCommandPalette({

src/utils/inlineEditable.js

@@ -257,6 +257,40 @@ export const moveInFocusedTableCell = (which) => {
   doMoveOp(root, opts, cell, which)
 }
 
+// Delete the focused cell's row/column. `which` ∈ 'row' | 'col'. No-op
+// if focus isn't in a cell, if the row is the header (we need it to keep
+// the table valid markdown), or if the table only has one row/column left.
+export const deleteInFocusedTableCell = (which) => {
+  let hostDoc = null
+  try { hostDoc = (window.top || window.parent)?.document } catch (_) { /* cross-origin */ }
+  if (!hostDoc) return
+  const active = hostDoc.activeElement
+  const cell = active && active.closest && active.closest('table.lsp-mdt th, table.lsp-mdt td')
+  if (!cell) return
+  const root = cell.closest('.lsp-mdtable-renderer')
+  const opts = root && root._lspInlineOpts
+  if (!opts) return
+  const tableEl = cell.closest('table.lsp-mdt')
+  const tr = cell.closest('tr')
+  const rows = Array.from(tableEl.querySelectorAll('tr'))
+  const rowIdx = rows.indexOf(tr)
+  const cells = Array.from(tr.querySelectorAll('th,td'))
+  const colIdx = cells.indexOf(cell)
+  const ord = Array.from(root.querySelectorAll('table.lsp-mdt')).indexOf(tableEl)
+  let op, newRow = rowIdx, newCol = colIdx
+  if (which === 'row') {
+    if (rowIdx < 1 || rows.length < 2) return // protect header / last row
+    op = tableOps.deleteRow
+    if (newRow >= rows.length - 1) newRow = rows.length - 2
+  } else if (which === 'col') {
+    if (cells.length < 2) return
+    op = tableOps.deleteCol
+    if (newCol >= cells.length - 1) newCol = cells.length - 2
+  } else return
+  pendingToolbar.set(opts.blockId, { ord, rowIdx: newRow, colIdx: newCol })
+  commitStructural(root, opts, (m, i) => (i === ord ? op(m, rowIdx, colIdx) : m))
+}
+
 // Shared by the local Alt+Shift+Arrow handler and the registered move
 // commands. Stashes a `pendingToolbar` entry at the moved cell's new
 // position so `resumePinnedToolbar` follows the cell after re-render.