feat(menu): drop Full screen, keep Maximise

VictorVow · VictorVow · commit cd7af778867b · 2026-05-20T07:16:22.000+01:00
Maximise (added in the previous commit) covers the same ground inside
Logseq's window — having both buttons is redundant. Removes the
fullScreenItem wiring from both surfaces, the :fullscreen CSS block,
the fullscreenchange resize listeners, the overlayHost fullscreen
branch, the Full screen / Exit full screen i18n strings, and their
menuLabels entries. fitInlineTableWidth now only branches on the
maximise class.
diff --git a/src/index.js b/src/index.js
@@ -241,28 +241,9 @@ if (isInBrowser) {
             outline: 2px solid var(--ls-active-primary-color, #2563eb) !important;
             outline-offset: -2px;
           }
-          /* Full-screen view uses the browser's native Fullscreen API so the
-             element overlays Logseq's UI regardless of ancestor stacking /
-             transform contexts. The DOM doesn't move, so inline editing,
-             the toolbar (mounted into the fullscreen element when active),
-             drag-drop and right-click menus all keep working. */
-          .lsp-mdtable-renderer:fullscreen {
-            margin: 0; padding: 24px 32px;
-            background: var(--ls-primary-background-color, #fff);
-            overflow: auto; box-sizing: border-box;
-          }
-          .lsp-mdtable-renderer:fullscreen .lsp-mdtable-scroll { overflow: auto; }
-          .lsp-mdtable-renderer:fullscreen table.lsp-mdt {
-            width: 100% !important; min-width: max-content;
-          }
-          .lsp-mdtable-renderer:fullscreen table.lsp-mdt th,
-          .lsp-mdtable-renderer:fullscreen table.lsp-mdt td {
-            padding: 8px 12px !important; font-size: 14px;
-          }
-          .lsp-mdtable-renderer:fullscreen .lsp-mdtable-text { font-size: 14px; }
-          /* Maximise: same look as fullscreen, but bounded by Logseq's window
-             rather than the OS desktop. The renderer is reparented to <body>
-             so ancestor transforms/overflow can't constrain this overlay. */
+          /* Maximise: expand the renderer to fill Logseq's window. The
+             renderer is reparented to <body> so ancestor transforms/overflow
+             can't constrain this overlay. */
           .lsp-mdtable-renderer.lsp-mdt-max {
             position: fixed; inset: 0; z-index: 2147483645;
             margin: 0; padding: 24px 32px;
@@ -427,8 +408,6 @@ if (isInBrowser) {
                       sortColDesc: i18n.t('Sort column descending'),
                       pinToolbar: i18n.t('Pin toolbar'),
                       unpinToolbar: i18n.t('Unpin toolbar'),
-                      fullScreen: i18n.t('Full screen'),
-                      exitFullScreen: i18n.t('Exit full screen'),
                       maximise: i18n.t('Maximise'),
                       exitMaximise: i18n.t('Exit maximise')
                     }
diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -9,8 +9,6 @@
   "delete column": "delete column",
   "normalise data": "normalise data (trim whitespace in cells)",
   "readable data": "readable data (align table source)",
-  "Full screen": "Full screen",
-  "Exit full screen": "Exit full screen",
   "Maximise": "Maximise",
   "Exit maximise": "Exit maximise",
   "Move row up": "Move row up",
diff --git a/src/locales/zh-CN/translation.json b/src/locales/zh-CN/translation.json
@@ -9,8 +9,6 @@
   "delete column": "删除列",
   "normalise data": "规范化数据（去除单元格首尾空格）",
   "readable data": "可读化（对齐表格源码）",
-  "Full screen": "全屏",
-  "Exit full screen": "退出全屏",
   "Maximise": "最大化",
   "Exit maximise": "退出最大化",
   "Move row up": "上移行",
diff --git a/src/utils/inlineEditable.js b/src/utils/inlineEditable.js
@@ -64,13 +64,10 @@ export const fitInlineTableWidth = (root) => {
     s.style.maxWidth = '0px'      // reflow to natural layout
     s.style.paddingRight = ''     // measure true overflow without our spacer
   })
-  // In fullscreen the renderer itself defines the available width; the
+  // When maximised the renderer itself defines the available width; the
   // Logseq block clip ancestor is irrelevant. Let the scroll wrapper fill
-  // the fullscreen viewport so the table can render edge-to-edge.
-  const doc = root.ownerDocument
-  const fsEl = doc.fullscreenElement || doc.webkitFullscreenElement
-  const maximised = root.classList.contains('lsp-mdt-max')
-  if ((fsEl && fsEl.contains(root)) || maximised) {
+  // the window so the table can render edge-to-edge.
+  if (root.classList.contains('lsp-mdt-max')) {
     scrolls.forEach(s => {
       s.style.maxWidth = '100%'
       if (s.scrollWidth > s.clientWidth + 1) {
@@ -111,8 +108,6 @@ const bindResizeRefit = (root) => {
     }, 100)
   }
   win.addEventListener('resize', refitAll)
-  doc.addEventListener('fullscreenchange', refitAll)
-  doc.addEventListener('webkitfullscreenchange', refitAll)
 }
 
 // Called from the renderer's ref on every (re-)mount, regardless of whether
@@ -435,20 +430,15 @@ const ICONS = {
   sortColAsc:  SVG('<path d="M11 5h3M11 10h6M11 15h9"/><polyline points="4 8 7 5 10 8"/><line x1="7" y1="5" x2="7" y2="19"/>'),
   sortColDesc: SVG('<path d="M11 5h9M11 10h6M11 15h3"/><polyline points="4 16 7 19 10 16"/><line x1="7" y1="5" x2="7" y2="19"/>'),
   pin: SVG('<line x1="12" y1="17" x2="12" y2="22"/><path d="M9 3h6l-1 6 3 3v2H7v-2l3-3-1-6z"/>'),
-  fullscreen:     SVG('<polyline points="4 9 4 4 9 4"/><polyline points="20 9 20 4 15 4"/><polyline points="4 15 4 20 9 20"/><polyline points="20 15 20 20 15 20"/>'),
-  exitFullscreen: SVG('<polyline points="9 4 9 9 4 9"/><polyline points="15 4 15 9 20 9"/><polyline points="4 15 9 15 9 20"/><polyline points="20 15 15 15 15 20"/>'),
   // Maximise = expand to Logseq's window bounds (covers sidebars/blocks).
-  // Distinct glyph from fullscreen so the two are distinguishable in the bar:
-  // a framed box with inward arrows.
+  // A framed box with inward arrows; the exit variant has the arrows outward.
   maximise:     SVG('<rect x="3" y="3" width="18" height="18" rx="1"/><polyline points="8 13 8 16 11 16"/><polyline points="16 11 16 8 13 8"/>'),
   exitMaximise: SVG('<rect x="3" y="3" width="18" height="18" rx="1"/><polyline points="13 8 16 8 16 11"/><polyline points="11 16 8 16 8 13"/>')
 }
 
-// Overlay host for popovers/toolbars: when the renderer is in native
-// fullscreen, doc.body sits beneath the fullscreen element's top layer and
-// our popups would be invisible. Mount them inside the fullscreen element
-// in that case so they share the top layer.
-const overlayHost = (doc) => doc.fullscreenElement || doc.webkitFullscreenElement || doc.body
+// Overlay host for popovers/toolbars. The renderer is reparented to <body>
+// while maximised, so mounting popups on <body> keeps them above it.
+const overlayHost = (doc) => doc.body
 
 const closeMenu = (doc) => {
   const el = doc.querySelector('.lsp-mdt-menu')
@@ -502,29 +492,6 @@ const buildItems = (root, opts, cell) => {
 
 const isPinned = (opts) => !!(opts.isPinned && opts.isPinned())
 
-// Full-screen toggle item; lives next to Pin/Unpin in both the right-click
-// menu and the pinned toolbar. Uses the native Fullscreen API on the
-// renderer root so the DOM doesn't move and all editing hooks stay bound.
-// `after(nowFs)` lets the surface refresh its item state.
-const fullScreenItem = (root, opts, after) => {
-  const doc = root.ownerDocument
-  const fsEl = doc.fullscreenElement || doc.webkitFullscreenElement
-  const isFs = fsEl === root
-  const L = opts.menuLabels || {}
-  return {
-    icon: isFs ? ICONS.exitFullscreen : ICONS.fullscreen,
-    label: isFs ? (L.exitFullScreen || 'Exit full screen') : (L.fullScreen || 'Full screen'),
-    enabled: true,
-    action: () => {
-      try {
-        if (isFs) (doc.exitFullscreen || doc.webkitExitFullscreen).call(doc)
-        else (root.requestFullscreen || root.webkitRequestFullscreen).call(root)
-      } catch (e) { console.warn('[mdtable] fullscreen toggle failed', e) }
-      if (after) after(!isFs)
-    }
-  }
-}
-
 // Maximise = expand the renderer to fill Logseq's window (covering sidebars
 // and other blocks), without entering OS-level fullscreen. Implementation:
 // reparent the renderer to <body> so ancestor transforms / overflow / stacking
@@ -580,7 +547,7 @@ const bindMaximiseEsc = (doc) => {
   }, true)
 }
 
-// Maximise toggle item; mirrors fullScreenItem's shape.
+// Maximise toggle item; lives next to Pin/Unpin in both surfaces.
 const maximiseItem = (root, opts, after) => {
   const max = isMaximised(root)
   const L = opts.menuLabels || {}
@@ -691,7 +658,6 @@ const buildToolbar = (root, opts, cell) => {
   const aRow = Array.from(cell.closest('table.lsp-mdt').querySelectorAll('tr')).indexOf(aTr)
   const aCol = Array.from(aTr.querySelectorAll('th,td')).indexOf(cell)
   const all = items.concat([{ sep: true },
-    fullScreenItem(root, opts, () => buildToolbar(root, opts, cell)),
     maximiseItem(root, opts, () => buildToolbar(root, opts, cell)),
     pinItem(opts, () => removeToolbar(doc))]) // pinned bar's toggle = unpin
 
@@ -728,7 +694,6 @@ const openContextMenu = (root, opts, cell, ev) => {
 
   const { items, ord } = buildItems(root, opts, cell)
   const all = items.concat([{ sep: true },
-    fullScreenItem(root, opts),
     maximiseItem(root, opts),
     pinItem(opts, (now) => { if (now) buildToolbar(root, opts, cell); else removeToolbar(doc) })])
 
