app/vlselect/logsql: fix silent log loss in live tail when entries share the same _time#1460
Open
cuongleqq wants to merge 1 commit into
Open
Conversation
…are the same _time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1459
The problem:
The live tail dedup in
getTailRowscompared only timestamps, so any new row arriving at the same_timeas the previous poll's last emitted row was dropped, even when content differed.Solution:
Track xxhash fingerprints of rows at the boundary timestamp, so new rows are distinguished by content rather than timestamp alone.