Skip to content

app/vlselect/logsql: fix silent log loss in live tail when entries share the same _time#1460

Open
cuongleqq wants to merge 1 commit into
VictoriaMetrics:masterfrom
cuongleqq:fix-live-tail-same-timestamp-dedup
Open

app/vlselect/logsql: fix silent log loss in live tail when entries share the same _time#1460
cuongleqq wants to merge 1 commit into
VictoriaMetrics:masterfrom
cuongleqq:fix-live-tail-same-timestamp-dedup

Conversation

@cuongleqq
Copy link
Copy Markdown
Contributor

Fixes #1459

The problem:
The live tail dedup in getTailRows compared only timestamps, so any new row arriving at the same _time as the previous poll's last emitted row was dropped, even when content differed.

Solution:
Track xxhash fingerprints of rows at the boundary timestamp, so new rows are distinguished by content rather than timestamp alone.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

live tail: silent log loss when multiple entries share the same _time

1 participant