lib/logstorage: fix typos in error messages and comments#1468
Open
immanuwell wants to merge 1 commit into
Open
lib/logstorage: fix typos in error messages and comments#1468immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Signed-off-by: Immanuel Tikhonov <pchpr.00@list.ru>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small typo fixes in 4 files:
block.go: panic message saysBUG: too valuesSize- missing word "big" (the panic 18 lines below forbloomFilterSizesays it correctly:BUG: too big bloomFilterSize)filter_string_range.go: comment saysmatches tie given string range(tie -> the)running_stats_last.go: error returned to user saysunexpeccted(doubled c)parser_test.go: sameunexpecctedin test failure messageHow to trigger the
running_stats_last.goone: pass wrong number of args tolast()in a running stats query, e.g.| running_stats last(a, b)- you get the misspelled error back.The
block.gopanic only fires when a values block exceedsmaxValuesBlockSize, which is a hard internal limit - so it's not user-triggerable in normal ops, but the message is still wrong when it does fire.