Skip to content

fix: VTK target reuse, OxidationStrategy refactor#231

Merged
FilipovicLado merged 7 commits into
masterfrom
fix-vtk-targets
Jun 25, 2026
Merged

fix: VTK target reuse, OxidationStrategy refactor#231
FilipovicLado merged 7 commits into
masterfrom
fix-vtk-targets

Conversation

@FilipovicLado

Copy link
Copy Markdown
Member
  • VTK double-loading fix: removes the ViennaPS-side workaround that
    prevented ViennaLS from double-loading VTK when consumed as a
    subdirectory. The fix now lives in ViennaLS ≥5.8.3, which checks for
    existing VTK::CommonCore targets before calling find_package(VTK).
    Bumps ViennaLS dependency floor to >=5.8.3.

  • OxidationStrategy: introduces a dedicated process strategy for
    models that manage their own time-stepping physics. Models override
    managesOwnPhysics() and applyModel() on ProcessModelBase;
    OxidationStrategy dispatches to them directly, replacing the
    previous AdvectionCallback/CallbackOnlyStrategy indirection.
    Extensible to future self-contained models (anneal, implant diffusion,
    etc.) without changes to psProcess.

  • psOxidation refactor: removes the OxidationCallback inner class,
    deduplicates the three material-search loops via a MaterialIndices
    helper, renames doApplyPreAdvectrun, resets
    toleranceWarningEmitted_ when tolerances are changed between runs,
    and removes a dead maxVelocity default parameter.

  • macOS arm64 CI: pins the package runner to macos-15
    macos-latest now resolves to macOS 26 (Tahoe) and breaks wheel
    builds because Homebrew libs are compiled with a 26.0 minimum
    deployment target.

Tests

  • All CI checks pass (Linux, Windows, macOS x86_64 + arm64)
  • All oxidation examples run correctly end-to-end
  • Python bindings build and import on all platforms

@FilipovicLado FilipovicLado merged commit f163c36 into master Jun 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant