fix: VTK target reuse, OxidationStrategy refactor#231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VTK double-loading fix: removes the ViennaPS-side workaround that
prevented ViennaLS from double-loading VTK when consumed as a
subdirectory. The fix now lives in ViennaLS ≥5.8.3, which checks for
existing
VTK::CommonCoretargets before callingfind_package(VTK).Bumps ViennaLS dependency floor to
>=5.8.3.OxidationStrategy: introduces a dedicated process strategy for
models that manage their own time-stepping physics. Models override
managesOwnPhysics()andapplyModel()onProcessModelBase;OxidationStrategydispatches to them directly, replacing theprevious
AdvectionCallback/CallbackOnlyStrategyindirection.Extensible to future self-contained models (anneal, implant diffusion,
etc.) without changes to
psProcess.psOxidation refactor: removes the
OxidationCallbackinner class,deduplicates the three material-search loops via a
MaterialIndiceshelper, renames
doApplyPreAdvect→run, resetstoleranceWarningEmitted_when tolerances are changed between runs,and removes a dead
maxVelocitydefault parameter.macOS arm64 CI: pins the package runner to
macos-15—macos-latestnow resolves to macOS 26 (Tahoe) and breaks wheelbuilds because Homebrew libs are compiled with a 26.0 minimum
deployment target.
Tests