feat(transaction): support run after transaction functionality#2742
Open
roggervalf wants to merge 2 commits into
Open
feat(transaction): support run after transaction functionality#2742roggervalf wants to merge 2 commits into
roggervalf wants to merge 2 commits into
Conversation
roggervalf
commented
Feb 17, 2025
| return Promise.reject(new Error('Run After transaction failed.')); | ||
| }); | ||
| } | ||
| if ((index + 1) % afterTransactionMethodsBatch === 0) { |
Contributor
Author
There was a problem hiding this comment.
as there could be many methods to be executed after transaction, better to do this operation in batches. In order to prevent thousands of promises in parallel that consume more resources that are available
roggervalf
commented
Feb 17, 2025
|
|
||
| return (knexOrTrx || this.knex()).transaction(cb); | ||
| return (knexOrTrx || this.knex()).transaction((trx) => { | ||
| trx.runAfterTransactionMethods = []; |
Contributor
Author
There was a problem hiding this comment.
extending trx object to save runAfterTransactionMethods and afterTransationMethodsBatch helpers.
Contributor
Author
|
Pls @lehni when you get some time. What do you think about this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as in #2582, where runAfterTransactionMethods is a collector of all methods to be executed after transaction is committed. All these methods are executed and only if at least 1 of them fail, an error is thrown.