Make union() deduplicate regardless of array size#2809
Open
Noethix55555 wants to merge 1 commit into
Open
Conversation
union() used a Set for large inputs but a plain copy of the first array for small ones, so duplicates in the first array survived only on the small-array path. union([1, 1, 2], [2, 3]) returned [1, 1, 2, 3] instead of [1, 2, 3]. Dedupe the first array on the small path too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
union()inlib/utils/objectUtils.jsswitches implementation based on input size: aSetfor large arrays (which dedupes both inputs) and a plain copy of the first array for small ones (which only dedupes the second). So duplicates in the first array survive only on the small-array path:The function is used when merging
RelationExpressionnodes ($modify,$childNames), where the result is expected to be a set.Fix dedupes the first array on the small path too, matching
unionGeneric. Added a case to theunionunit tests intests/unit/utils.js; it fails on the current code and passes with the change. The fulltests/unit/utils.jssuite passes.