Skip to content

Commit 69ff050

Browse files
fix: CORE-1638 add to pr hygene error instructions (#71)
* test: Update validate_pr_test.sh * fix: add PR title validation error message * fix: simplify message
1 parent 7227a25 commit 69ff050

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

.github/actions/validate-pr/validate_pr.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,8 @@ Details:
7979
- Current title: $PR_TITLE
8080
Action: Update the PR title to start with a valid semantic prefix
8181
Valid prefixes: feat:, fix:, chore:, docs:, style:, refactor:, perf:, test:
82-
Example: feat: Add new feature (ABC-123)"
82+
Example: feat: Add new feature (ABC-123)
83+
Note: You must push a new commit to update this validation result"
8384
exit 1
8485
fi
8586

@@ -135,4 +136,4 @@ Expected format: release/v$PACKAGE_VERSION or hotfix/v$PACKAGE_VERSION"
135136
fi
136137
fi
137138

138-
echo "PR title and branch name validation passed."
139+
echo "PR title and branch name validation passed."

.github/actions/validate-pr/validate_pr_test.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ Details:
4242
- Current title: This is a PR title (ISSUE-1234)
4343
Action: Update the PR title to start with a valid semantic prefix
4444
Valid prefixes: feat:, fix:, chore:, docs:, style:, refactor:, perf:, test:
45-
Example: feat: Add new feature (ABC-123)"
45+
Example: feat: Add new feature (ABC-123)
46+
Note: You must push a new commit to update this validation result"
4647

4748
echo Scenario: PR title missing Jira ticket for feature branch
4849
beforeEach

0 commit comments

Comments
 (0)