[fix] js component bugs#4
Open
gmacmaster wants to merge 2 commits into
Open
Conversation
…on Windows - Fix hover-out delay timeout being assigned to _hoverInDelayTimeout instead of _hoverOutDelayTimeout, which prevented proper cancellation - Remove misleading nullish coalescing in onStartShouldSetResponder since !disabled always produces a boolean Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
tabIndex used boolean negation (!tabIndex) which made any positive tabIndex (1, 2, etc.) incorrectly set focusable to false. Changed to tabIndex >= 0 to match ARIA/web standard behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Greptile SummaryThis PR fixes three distinct bugs across two Windows-specific React Native files. The changes are all straightforward correctness fixes with no new logic introduced. Confidence Score: 5/5All three changes are well-targeted bug fixes with no regressions introduced — safe to merge. Every change corrects a clear pre-existing defect (wrong boolean logic for tabIndex, dead nullish-coalescing on a guaranteed boolean, wrong timeout property in hover-out handler). No new logic, no P0/P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Fix tabIndex to focusable mapping for po..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.