Return compound types#30
Merged
Merged
Conversation
Introduce support for foreign module field types and skip computed fields during relation expansion. Changed ModuleFieldType from a struct to an enum (Own { type_id, type_name } | Foreign(ForeignModuleType)) and updated Named::name accordingly. Updated the type builder to emit ForeignModuleType for fields that reference types in other modules, and adjusted database_builder to early-return for computed fields. Also bumps workspace version and updates Cargo.lock dependencies.
|
Version bump detected: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new distinction between "own" and "foreign" module field types in the subsystem model builder utilities, improving type safety and clarity when handling fields that reference types from other modules. It also updates the workspace version and skips computed fields during type relation expansion.
Module field type improvements:
ModuleFieldTypefrom a struct to an enum with two variants:Own(for types defined in the current module) andForeign(for types imported from other modules), allowing for more precise modeling of field origins.create_module_fieldand related logic to construct either anOwnorForeignModuleFieldTypebased on the presence of amodule_namein the field, enhancing support for cross-module references.ForeignModuleTypeto the imports, supporting the new enum variant inModuleFieldType.Other improvements:
0.29.5to0.29.6.