Prevent removal of machines with assigned services#5
Merged
Conversation
Ensures machines cannot be removed if user services are still assigned, preventing orphaned user service records from counting against the limit and improving data consistency.
dkmstr
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an important validation to the
FixedServiceinitialization logic to prevent removing machines that still have assigned user services. This change ensures that machines with active user services cannot be inadvertently removed, which would otherwise cause lingering user service records and potentially impact the enforcement of user service limits.Validation improvements:
Minor code maintenance:
service.py.