Skip to content

Commit 2bbc908

Browse files
committed
Update performance thresholds to reflect improved query times
1 parent 896dea1 commit 2bbc908

3 files changed

Lines changed: 13 additions & 13 deletions

File tree

.github/workflows/performance-test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ jobs:
5757
5858
## Performance Thresholds
5959
60-
- Maximum single query time: 5 minutes (300 seconds)
61-
- Maximum total time for both queries: 7.5 minutes (450 seconds)
60+
- Maximum single query time: 2 seconds
61+
- Maximum total time for both queries: 4 seconds
6262
6363
## Test Results
6464

performance.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ This performance test measures the execution time of VFB term info queries for s
1414

1515
## Performance Thresholds
1616

17-
- Maximum single query time: 5 minutes (300 seconds)
18-
- Maximum total time for both queries: 7.5 minutes (450 seconds)
17+
- Maximum single query time: 2 seconds
18+
- Maximum total time for both queries: 4 seconds
1919

2020
## Test Results
2121

src/test/term_info_queries_test.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -551,14 +551,14 @@ def test_term_info_performance(self):
551551

552552
# Performance categories
553553
total_time = duration_1 + duration_2
554-
if total_time < 60:
555-
performance_level = "🟢 Excellent (< 1 minute)"
556-
elif total_time < 180:
557-
performance_level = "🟡 Good (1-3 minutes)"
558-
elif total_time < 300:
559-
performance_level = "🟠 Acceptable (3-5 minutes)"
554+
if total_time < 1.0:
555+
performance_level = "🟢 Excellent (< 1 second)"
556+
elif total_time < 2.0:
557+
performance_level = "🟡 Good (1-2 seconds)"
558+
elif total_time < 4.0:
559+
performance_level = "🟠 Acceptable (2-4 seconds)"
560560
else:
561-
performance_level = "🔴 Slow (> 5 minutes)"
561+
performance_level = "🔴 Slow (> 4 seconds)"
562562

563563
print(f"Performance Level: {performance_level}")
564564
print(f"="*50)
@@ -569,8 +569,8 @@ def test_term_info_performance(self):
569569

570570
# Performance assertions - fail if queries take too long
571571
# These thresholds are based on observed performance characteristics
572-
max_single_query_time = 300.0 # seconds (5 minutes)
573-
max_total_time = 450.0 # seconds (7.5 minutes)
572+
max_single_query_time = 2.0 # seconds
573+
max_total_time = 4.0 # seconds (2 queries * 2 seconds each)
574574

575575
self.assertLess(duration_1, max_single_query_time,
576576
f"FBbt_00003748 query took {duration_1:.4f}s, exceeding {max_single_query_time}s threshold")

0 commit comments

Comments
 (0)